Skip to content

BREAKING CHANGE : upgrade nodejs support till 24 and fix security vulns#110

Open
samarpanB wants to merge 3 commits into
postmanlabs:masterfrom
samarpanB:master
Open

BREAKING CHANGE : upgrade nodejs support till 24 and fix security vulns#110
samarpanB wants to merge 3 commits into
postmanlabs:masterfrom
samarpanB:master

Conversation

@samarpanB
Copy link
Copy Markdown

@samarpanB samarpanB commented Jan 4, 2026

BREAKING CHANGE

This PR fixes a lot of security vulnerabilities which are showing up through npm audit. It also adds support for latest active and LTS nodejs versions. It removes non-maintained linter and coverage tools and replaces them with drop-in replacements. No logical or code change has been done except for lint issue fixes.

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

@samarpanB
Copy link
Copy Markdown
Author

@appurva21 can you please review this ? All the test cases are passing in this now. You can check that here - samarpanB#1 .

@jean-dusenne
Copy link
Copy Markdown

Hello @samarpanB ,

There are many changes in this PR.

Are all the changes related to this CVE?
Some changes seem to be related to the linter. To facilitate validation, shouldn't you propose another PR with these changes?

@samarpanB
Copy link
Copy Markdown
Author

Hello @samarpanB ,

There are many changes in this PR.

Are all the changes related to this CVE? Some changes seem to be related to the linter. To facilitate validation, shouldn't you propose another PR with these changes?

The problem is, in order to fix this CVE I need to update the nodejs version and hence its related dependencies also needed an upgrade. Without this, the CVE fix wasn't feasible. To ensure nothing is broken, I have ensured test cases are working.

@samarpanB
Copy link
Copy Markdown
Author

Hello @samarpanB ,

There are many changes in this PR.

Are all the changes related to this CVE? Some changes seem to be related to the linter. To facilitate validation, shouldn't you propose another PR with these changes?

Here is a PR for that #111. But I am not sure if test cases are passing on this one. That was my issue and concern. Hence this PR got big.

@samarpanB samarpanB changed the title BREAKING CHANGE : drop support for nodejs till 18 and fix security vulns BREAKING CHANGE : upgrade nodejs support till 24 and fix security vulns Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants