Add Semaphore utility to help implement connection pools#906
Open
Add Semaphore utility to help implement connection pools#906
Semaphore utility to help implement connection pools#906Conversation
🦋 Changeset detectedLatest commit: e6d0c2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have two manual connection pool implementations in this repository:
@powersync/nodeand@powersync/op-sqlite. Both implementations share a similar architecture:Mutexto guard access to the write connection.busyflag and have a queue of readers backed by an array.For VFS implementations that allow concurrent access on the web, we'll soon have a third connection pool implementation. Adding the third copy-paste is always a good signal to refactor, so this PR adds utilities for implementing connection pools to
@powersync/common.The
Semaphoreclass wraps an array of inner elements and can give out leases wrapping a single or multiple such elements. These are all acquired atomically, and requests on semaphores can be aborted individually. This is pretty much the same implementation we already had for pools, except that:O(n)Array.shift()when removing elements.Semaphoreimplementation, we get to abort readers (which both@powersync/nodeand@powersync/op-sqlitedidn't really support before).close()andrefreshSchema()now use the respective connection locks as well, avoiding potential concurrency issues.Hopefully this is the last refactoring item for concurrent reads on the web :D