Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the compact process to read from secondaries (
readPreference: 'secondaryPreferred').The main goal here is to reduce load on primary MongoDB nodes, by shifting these bulk reads to secondaries.
In general, reading stale data is not an issue for compacting. There are cases where we want to read our own writes, so we use a session with causal consistency for this. This specifically means setting the
readConcern: { level: 'majority' }andwriteConcern: { w: 'majority' }as well, to get all the guarantees we need.We may be able to relax some of the guarantees later to improve throughput, for example by using a separate session for reads vs writes. That gets more complex though, so leaving that for another project.
We can also consider making the read preference configurable in the future, for example to allow allow these reads on secondaries, and rather fail if a secondary isn't available.
TODO: