Skip to content

ci: add batch clippy lints (get_unwrap, if_then_some_else_none, derive_partial_eq_without_eq)#65

Merged
poyrazK merged 1 commit intomainfrom
ci/deny-map-unwrap-or-lint
Apr 19, 2026
Merged

ci: add batch clippy lints (get_unwrap, if_then_some_else_none, derive_partial_eq_without_eq)#65
poyrazK merged 1 commit intomainfrom
ci/deny-map-unwrap-or-lint

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented Apr 19, 2026

Summary

Add 4 new clippy lints to CI deny list:

  • clippy::get_unwrap — 3 fixes
  • clippy::if_then_some_else_none — 4 fixes
  • clippy::derive_partial_eq_without_eq — 1 fix
  • clippy::unnecessary_literal_unwrap — 0 warnings (add directly)

Files changed

  • .github/workflows/ci.yml
  • rust/crates/cloudsearch-common/src/lib.rs
  • rust/crates/cloudsearch-index/src/lib.rs
  • rust/crates/cloudsearch-storage/src/lib.rs

Test plan

  • cargo clippy --workspace --all-targets -- -D warnings passes with all new lints
  • Tests pass

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 19, 2026

Warning

Rate limit exceeded

@poyrazK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 53 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 53 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c7903023-43df-4328-9f43-728be86872ff

📥 Commits

Reviewing files that changed from the base of the PR and between c82bdc3 and 57e6525.

📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • rust/crates/cloudsearch-common/src/lib.rs
  • rust/crates/cloudsearch-index/src/lib.rs
  • rust/crates/cloudsearch-storage/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/deny-map-unwrap-or-lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Fix 5 instances of `map().unwrap_or(x)` which should be
`map_or(x, |...|)` to avoid eager evaluation of the default.

Auto-fixed by cargo clippy --fix.
@poyrazK poyrazK force-pushed the ci/deny-map-unwrap-or-lint branch from 6d56055 to 57e6525 Compare April 19, 2026 17:20
Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK poyrazK merged commit 9a4cb2f into main Apr 19, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant