Open
Conversation
Instead of allocating a full polyveck for h in attempt_signature_generation, compute cs2, ct0, and hints one polynomial at a time using scratch polys. This eliminates the polyveck h from the yh_u union, replacing mld_pack_sig_c_h with incremental packing via mld_pack_sig_c and mld_pack_sig_h_poly. This is a prerequisite for also eliminating y in a follow up. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Replace the row-level matrix buffer (mld_polyvecl) with a single-poly buffer in REDUCE_RAM mode. In the lazy path, matrix elements A[k][l] are sampled on demand one at a time, and the matrix-vector product accumulates element-by-element instead of row-by-row. Restructure polymat into eager/lazy variants following the same pattern as s1hat/s2hat/t0hat: - mld_polymat_eager: stores full K x L matrix - mld_polymat_lazy: stores rho + single poly_buffer + tmp - mld_polyvec_matrix_expand_eager/_lazy: separate implementations - mld_polyvec_matrix_pointwise_montgomery_eager/_lazy: separate implementations with CBMC contracts only on the eager variants Move all polymat-related code from polyvec.h/polyvec.c into polyvec_lazy.h/polyvec_lazy.c. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
d7de92e to
0f60231
Compare
Contributor
CBMC Results (ML-DSA-44)
Full Results (182 proofs)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (182 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (182 proofs)
|
Introduce mld_zvec following the lazy polyvec pattern (eager / lazy
variants with #define dispatch on MLD_CONFIG_REDUCE_RAM):
- mld_zvec_init: in eager mode unpacks the full polyvecl, performs the
polyvecl-wide infinity-norm bound check, and NTTs in place. In lazy
mode it just stores a pointer to the packed signature bytes.
- mld_zvec_get_poly: in eager mode copies a single polynomial from
the precomputed vector. In lazy mode unpacks one polynomial,
performs the per-poly infinity-norm bound check, and NTTs into
the caller-provided buffer.
The norm check thus moves out of mld_sign_verify_internal into the
zvec init / get_poly accessors, so the verify body no longer has to
sequence chknorm explicitly.
Add a fused matrix-vector helper
mld_polyvec_matrix_pointwise_montgomery_zvec used by verify:
- The eager variant is a thin wrapper around the existing
mld_polyvec_matrix_pointwise_montgomery_eager (z is already NTT'd
by mld_zvec_init).
- The lazy variant streams z via mld_zvec_get_poly_lazy and generates
the matrix on-the-fly column-by-column,
accumulating A[*,l] * z[l] into w.
In REDUCE_RAM mode this avoids holding the full unpacked polyvecl z
in memory at once, reducing verify allocation by 2-5 KiB per parameter
set.
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
0f60231 to
947662d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce mld_zvec following the lazy polyvec pattern (eager / lazy
variants with #define dispatch on MLD_CONFIG_REDUCE_RAM):
polyvecl-wide infinity-norm bound check, and NTTs in place. In lazy
mode it just stores a pointer to the packed signature bytes.
the precomputed vector. In lazy mode unpacks one polynomial,
performs the per-poly infinity-norm bound check, and NTTs into
the caller-provided buffer.
The norm check thus moves out of mld_sign_verify_internal into the
zvec init / get_poly accessors, so the verify body no longer has to
sequence chknorm explicitly.
Add a fused matrix-vector helper
mld_polyvec_matrix_pointwise_montgomery_zvec used by verify:
mld_polyvec_matrix_pointwise_montgomery_eager (z is already NTT'd
by mld_zvec_init).
the matrix on-the-fly column-by-column,
accumulating A[*,l] * z[l] into w.
In REDUCE_RAM mode this avoids holding the full unpacked polyvecl z
in memory at once, reducing verify allocation by 2-5 KiB per parameter
set.