Draft
Conversation
hanno-becker
force-pushed
the
ppc64le_backend
branch
3 times, most recently
from
259a5a3 to
346cc92
Compare
hanno-becker
force-pushed
the
ppc64le_backend
branch
from
346cc92 to
191ebbb
Compare
hanno-becker
force-pushed
the
ppc64le_backend
branch
2 times, most recently
from
4005fdf to
fbdf60e
Compare
|
@hanno-becker Will take a look. |
The supported native functions include: 1. MLK_USE_NATIVE_NTT (ntt_ppc.S) 2. MLK_USE_NATIVE_INTT (intt_ppc.S) 3. MLK_USE_NATIVE_POLY_REDUCE (reduce.S) 4. MLK_USE_NATIVE_POLY_TOMONT (poly_tomont.S) And other interface functions and headers. Signed-off-by: Danny Tsen <dtsen@us.ibm.com>
This commit prepares scripts/autogen and scripts/cfify for the work-in-progress addition of riscv64 and ppc64le backends. Specifically, simpasm needs to be invoked with the right cross compiler for those architectures, and scripts/cfify needs to accept riscv64 and ppc64le architecture parameters. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
hanno-becker
force-pushed
the
ppc64le_backend
branch
from
fbdf60e to
07e9c81
Compare
mkannwischer
added a commit
that referenced
this pull request
Dec 18, 2025
Courtesy of Basil Hess/IBM, we know have a self-hosted POWER10 runner. This commit adds functional tests to CI. I had attempted to add it to the existign "kat_tests", but the sanitizer tests don't work properly on that platform. Note that opt tests are already enabled so that #1193 can simply be rebased on top of this. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
mkannwischer
added a commit
that referenced
this pull request
Dec 18, 2025
Courtesy of Basil Hess/IBM, we know have a self-hosted POWER10 runner. This commit adds functional tests to CI. I had attempted to add it to the existign "kat_tests", but the sanitizer tests don't work properly on that platform. Note that opt tests are already enabled so that #1193 can simply be rebased on top of this. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
mkannwischer
added a commit
that referenced
this pull request
Dec 18, 2025
Courtesy of Basil Hess/IBM, we know have a self-hosted POWER10 runner. This commit adds functional tests to CI. I had attempted to add it to the existign "kat_tests", but the sanitizer tests don't work properly on that platform. Note that opt tests are already enabled so that #1193 can simply be rebased on top of this. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
hanno-becker
pushed a commit
that referenced
this pull request
Dec 18, 2025
Courtesy of Basil Hess/IBM, we know have a self-hosted POWER10 runner. This commit adds functional tests to CI. I had attempted to add it to the existign "kat_tests", but the sanitizer tests don't work properly on that platform. Note that opt tests are already enabled so that #1193 can simply be rebased on top of this. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
hanno-becker
pushed a commit
that referenced
this pull request
Dec 18, 2025
Courtesy of Basil Hess/IBM, we know have a self-hosted POWER10 runner. This commit adds functional tests to CI. I had attempted to add it to the existign "kat_tests", but the sanitizer tests don't work properly on that platform. Note that opt tests are already enabled so that #1193 can simply be rebased on top of this. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Contributor
|
Marking this as draft - @bhess, please feel free to continue here or start your own branch. Please mark it as ready for review when you need some feedback. |
|
@mkannwischer I don't have write access to this branch, ppc64le_backend so I can't commit my patch. Or do you prefer I create another PR? Thanks. |
|
@mkannwischer OK. I just created a new PR against this branch, #1647 . Please review the code. @bhess Please also review the code. Thanks. |
@mkannwischer @bhess I'm sorry. I may have created a PR from a wrong branch of my repo. I have to close it and re-do. |
|
@mkannwischer @bhess I have re-created a new PR against the main branch which is much cleaner, #1648. Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #1184, taking care of integration and testing.
autogenas done for the other backends