Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An HTML tutorial URL that responds to HEAD with HTTP 200 is currently accepted without fetching its body. Since HEAD has no response body, the existing soft-404 title detector never sees 'Page not found', and a missing tutorial can be reported as OK.
Fetch HTML/XHTML bodies with the existing bounded GET path after a successful HEAD. Also fetch when Content-Type is absent. Non-HTML resources keep the HEAD-only path; redirects and unsupported HEAD requests retain their existing handling.
Add nine offline regression tests using a local HTTP server. Cover soft-404 detection, normal HTML, missing Content-Type, XHTML, binary resources, redirects, HEAD fallback, domain-policy overrides and HTTP 410. Run the tests in the validation workflow and trigger that workflow for tooling changes.
Validation:
Tradeoff: successful HTML links now require one extra bounded request. No third-party dependencies are added. Hosted GitHub Actions has not been run locally; only its workflow configuration was updated.
This is a tooling-only change. AI assistance: Codex investigated, implemented and validated it.