-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Alliance Gravity Bid Adapter #14267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Alliance Gravity Bid Adapter #14267
Conversation
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
modules/alliancegravityBidAdapter.ts
Outdated
|
|
||
| export const getGzipSetting = (): boolean => { | ||
| const getBidderConfig = config.getBidderConfig(); | ||
| if (getBidderConfig.nexx360?.gzipEnabled === 'true') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this hold-over code from the initial setup? if it's not, why are you looking at another bidder's setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was indeed, sorry for that
it is fixed
jsnellbaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 areas that need review/confirmation. Otherwise things look ok.
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
@danielbaud Thank you for making the requested updates; can you please confirm though if the test credetials for the adUnit are setup to return a working test bid? Presently, I'm not seeing anything return from the endpoint but the following: As part of the initial adapter creation PR, we have to review the e2e workflow with a test bid to ensure everything's working as expected. Thanks. |
Type of change
Description of change
Addition of Alliance Gravity Bid Adapter
Other information