Skip to content

Conversation

@danielbaud
Copy link

@danielbaud danielbaud commented Dec 13, 2025

Type of change

  • New bidder adapter

Description of change

Addition of Alliance Gravity Bid Adapter

{
  bidder: 'alliance_gravity',
  params: {
    srid: '11223344'
  }
}

Other information

@danielbaud danielbaud marked this pull request as draft December 13, 2025 17:47
@github-actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/pubmaticRtdProvider.js (+1 error)

@github-actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/pubmaticRtdProvider.js (+1 error)

@danielbaud danielbaud marked this pull request as ready for review December 15, 2025 14:19

export const getGzipSetting = (): boolean => {
const getBidderConfig = config.getBidderConfig();
if (getBidderConfig.nexx360?.gzipEnabled === 'true') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this hold-over code from the initial setup? if it's not, why are you looking at another bidder's setting?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was indeed, sorry for that
it is fixed

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 areas that need review/confirmation. Otherwise things look ok.

@github-actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/pubmaticRtdProvider.js (+1 error)

@github-actions
Copy link

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • modules/alliance_gravityBidAdapter.ts (+1 error)
  • modules/pubmaticRtdProvider.js (+1 error)

@github-actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/pubmaticRtdProvider.js (+1 error)

@jsnellbaker
Copy link
Collaborator

@danielbaud Thank you for making the requested updates; can you please confirm though if the test credetials for the adUnit are setup to return a working test bid? Presently, I'm not seeing anything return from the endpoint but the following:

{
    "id": "bade823d-7d74-4124-a001-feb2fa226610",
    "nbr": 2,
    "ext": {
        "warnings": {
            "general": [
                {
                    "code": 10002,
                    "message": "debug turned off for account"
                }
            ]
        },
        "tmaxrequest": 1000,
        "prebid": {
            "auctiontimestamp": 1766761642871
        }
    }
}

As part of the initial adapter creation PR, we have to review the e2e workflow with a test bid to ensure everything's working as expected. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants