New Adapter: TRUSTX (remove Grid alias) #4614

trustXops · 2025-11-26T15:16:07Z

github-actions · 2025-11-26T15:17:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 6e452fe

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	81.8%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:82:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:116:	setImpExtData	87.5%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:130:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:162:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:193:	getBidMeta	100.0%
total:									(statements)	96.2%

karwaankit32 · 2026-01-09T09:51:27Z

Please rebase this PR with the latest changes as that is causing the server to not be up due to a bug which has been fixed

github-actions · 2026-01-09T10:16:01Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2b6b83f

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	81.8%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:82:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:116:	setImpExtData	87.5%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:130:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:162:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:193:	getBidMeta	100.0%
total:									(statements)	96.2%

trustXops · 2026-01-09T10:21:44Z

Hi @karwaankit32, rebased! Is there anything else I can do to expedite merging this PR?

karwaankit32 · 2026-01-09T10:23:06Z

Hi @karwaankit32, rebased! Is there anything else I can do to expedite merging this PR?

Thanks. I am in the process of reviewing the PR today and will post feedback by EOD. Thanks!

karwaankit32 · 2026-01-09T09:49:17Z

adapters/trustx/params_test.go

+}
+
+var validParams = []string{
+	`{}`,


Question: is a default Uid being 0 acceptable here? Is there a reason why we are not making Uid required?

Hi, 0 is acceptable, as publishers can also pass the value in other fields (e.g. imp.tagid)

karwaankit32 · 2026-01-09T09:50:32Z

adapters/trustx/params_test.go

+	`{"uid": 1234}`,
+	`{"uid": 1234, "keywords":{"site": {}, "user": {}}}`,
+}
+var invalidParams = []string{


Can we add other test cases where we also check data types of Uid and Keywords?
Ex: passing a "string" Uid and similarly for Keywords?

Added 2 test cases.

karwaankit32 · 2026-01-09T13:43:40Z

adapters/trustx/trustx.go

+func setImpExtData(imp *openrtb2.Imp) {
+	var ext impExt
+	if err := jsonutil.Unmarshal(imp.Ext, &ext); err != nil {
+		return


do we want to log these errors?

I don't think so, as the data read from the imp ext (adslot) is optional to us, and the request is valid without it.

Makes sense but i'd recommend adding a test case for this

Added a test case for this!

karwaankit32 · 2026-01-09T14:02:16Z

adapters/trustx/trustx.go

+		return nil
+	}
+	var bidMeta *openrtb_ext.ExtBidPrebidMeta
+	if be.Bidder.TrustX.NetworkName != "" {


Can there be a case where TrustX is empty? Won't this logic break in such cases?

Yes, there can be a case where we don't return the network name, but TrustX isn't a pointer so nothing will break, bid meta will just be nil.

github-actions · 2026-01-09T15:50:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 058ffe5

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	81.8%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:82:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:116:	setImpExtData	87.5%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:130:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:162:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:193:	getBidMeta	100.0%
total:									(statements)	96.2%

github-actions · 2026-01-09T16:23:48Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5cc01b6

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	81.8%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:82:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:116:	setImpExtData	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:130:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:162:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:193:	getBidMeta	100.0%
total:									(statements)	97.5%

trustXops mentioned this pull request Nov 26, 2025

Trustx bidder adapter prebid/prebid.github.io#6355

Open

6 tasks

bsardo added the adapter label Dec 3, 2025

Submit trustx adapter

2b6b83f

trustXops force-pushed the trustx-bidder-adapter branch from 6e452fe to 2b6b83f Compare January 9, 2026 10:15

karwaankit32 reviewed Jan 9, 2026

View reviewed changes

additional test cases for parameters

058ffe5

add a test case for invalid imp ext

5cc01b6

karwaankit32 approved these changes Jan 9, 2026

View reviewed changes

New Adapter: TRUSTX (remove Grid alias) #4614

Are you sure you want to change the base?

New Adapter: TRUSTX (remove Grid alias) #4614

Uh oh!

Conversation

trustXops commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025

Code coverage summary

trustx

Uh oh!

karwaankit32 commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2026

Code coverage summary

trustx

Uh oh!

trustXops commented Jan 9, 2026

Uh oh!

karwaankit32 commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 9, 2026

Code coverage summary

trustx

Uh oh!

github-actions bot commented Jan 9, 2026

Code coverage summary

trustx

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

trustXops commented Nov 26, 2025 •

edited

Loading

karwaankit32 commented Jan 9, 2026 •

edited

Loading