Skip to content

chore: Remove jlap support#5592

Closed
hunger wants to merge 1 commit intoprefix-dev:feature/lockfile-v7from
hunger:push-ryqzsrlmzwkn
Closed

chore: Remove jlap support#5592
hunger wants to merge 1 commit intoprefix-dev:feature/lockfile-v7from
hunger:push-ryqzsrlmzwkn

Conversation

@hunger
Copy link
Contributor

@hunger hunger commented Mar 3, 2026

Rattler removed this, so it needs to go here as well.

How Has This Been Tested?

Poorly?

AI Disclosure

No Ai

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

Rattler removed this, so it needs to go here as well.
@hunger hunger requested a review from baszalmstra March 3, 2026 12:15
@hunger
Copy link
Contributor Author

hunger commented Mar 3, 2026

This is just a PR we need to get pixi up and running with the rattler as it was when we started the feature/lockfile-v7 branch there.

Note: The pixi-build stuff was in a horrible state when I started, so I just removed that entirely.

Looks like the CI is not overly helpful due to all that:-/

@@ -1,16 +1,23 @@
[workspace]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes also needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to disable anything depending directly or indirectly on rattler-build: Back when I created this branch, rattler-build was in the middle of a pretty big refactor.

Fixing this will require rebasing. I would love to do that once in the end.

@baszalmstra baszalmstra force-pushed the feature/lockfile-v7 branch 9 times, most recently from f352b94 to 63e87d8 Compare March 6, 2026 15:09
@baszalmstra
Copy link
Contributor

Closing in favor of #5607

@baszalmstra baszalmstra closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants