Support arbitrary selector expressions in package targets#5717
Closed
Support arbitrary selector expressions in package targets#5717
Conversation
Allow arbitrary selector expressions (e.g. "host_platform == build_platform") as target keys in the [package] section. These are passed through directly to rattler-build, enabling full control over conditional dependencies. Expression selectors are only valid in [package.target] and [package.build.target] sections. In workspace and feature sections, unknown platform strings still produce proper error messages. Closes #4625 https://claude.ai/code/session_013pXmuPTy8PtK6p6jrRKWJc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for arbitrary selector expressions (e.g.,
"host_platform == build_platform") in the[package.target]section of manifests. These expressions are passed through directly to rattler-build for evaluation, enabling more complex conditional logic in package configurations.E.g. this should enable: