fix: respect configs with stdin-path set#113
Open
43081j wants to merge 1 commit into
Open
Conversation
Fixes #21. This extracts the config loading into a new `getConfigNames` helper function which both `runStdin` and `runGlobs` call. In `runStdin`, we only run it if there is a `stdinFilepath` set. In the case the `stdinFilepath` doesn't exist, we still get the config from the `cwd` (just like `runGlobs`).
commit: |
43081j
commented
Jul 8, 2026
| } | ||
| }); | ||
| }; | ||
| const getEditorConfig: typeof getEditorConfigImpl = memoize(getEditorConfigImpl); |
Collaborator
Author
There was a problem hiding this comment.
typescript errors on main if we don't do this. i guess it got bumped at some point and is no longer happy about the return type using an unexported type (as in we don't re-export it)
fisker
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
This extracts the config loading into a new
getConfigNameshelperfunction which both
runStdinandrunGlobscall.In
runStdin, we only run it if there is astdinFilepathset.In the case the
stdinFilepathdoesn't exist, we still get the configfrom the
cwd(just likerunGlobs).