feat(regexp): update parseRegExpString to support modern regex flags (u, s)#93
Open
myakura wants to merge 2 commits into
Open
feat(regexp): update parseRegExpString to support modern regex flags (u, s)#93myakura wants to merge 2 commits into
myakura wants to merge 2 commits into
Conversation
- Update regexpRegexp pattern to capture u (unicode) and s (dotAll) flags - Add tests for unicode flag, dotAll flag, and combined modern flags - Fixes issue where /pattern/us in YAML config would silently drop u and s flags
myakura
changed the title
- Mark task 04 as implemented in ROADMAP.md (PR prh#93 opened) - Update issue.md with completed status and PR link - Update regexp-modernization.md with implemented status - Update regexp-bugs.md to show issue is fixed
vvakame
requested changes
May 17, 2026
Collaborator
vvakame
left a comment
vvakame
left a comment
There was a problem hiding this comment.
thanks to contributios!
Could you remove _myakura/ directory?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ES2020までに追加された新しいフラグをregexp.tsの
parseRegExpString()に追加し、これらを認識できるようにします。Summary
parseRegExpStringto recognizeu(unicode) ands(dotAll) flags/pattern/usin YAML config would silently dropuandsflagsChanges
lib/utils/regexp.ts: UpdatedregexpRegexppattern from/^\/(.*)\/([gimy]*)$/to/^\/(.*)\/([gimsuy]*)$/test/utils/regexpSpec.ts: Added 3 new test cases:/\\p{Script=Han}/u)/./s)/pattern/gimsuy)Testing
All 32 regexp tests pass. The fix ensures users can now use
uandsflags in their YAML rule patterns.