v16 - major upgrade#46
Open
pritambiswal wants to merge 20 commits into
Open
Conversation
… parser Three issues preventing Purchase Invoice creation from incoming EDocuments: 1. Items not matched by name: when no matching_data, buyer_item_id or seller_product_id match exists, try matching by item_name (exact match on Item doctype). Without item_code, set_missing_item_details skips the item and expense_account is never resolved. 2. Tax account_head left empty: the tax guessing stub was a no-op. Now looks up account_head from existing Purchase Taxes templates matching the rate and company. 3. Payment schedule entry with only due_date (no payment_amount) caused a TypeError in set_payment_schedule. Don't create a default entry; let ERPNext compute it from payment_terms_template.
…parser fix: add frappe-dependencies for Frappe Cloud compatibility
fix: prevent modifications to transmitted edocuments
fix: match buyer company by tax ID instead of name
fix: resolve missing item, tax account and payment schedule in PEPPOL parser
- Always add TaxCategory to AllowanceCharge elements (BR-32 compliance) - Only use InvoiceTypeCode 384 when both parties are German organizations - Normalize negative signs for credit notes (abs on qty, amounts, totals) - Handle invoice deduction lines (negative amount moved to quantity) - Use consistent 2-decimal formatting for all monetary XML values
…nd-br32-validation fix: PEPPOL generator validation fixes and credit note sign handling
chore: add apt deploy dependencies for lxml
- Move negative sign from qty to rate on non-return invoices - Replace manual tax row building with header/item tax template lookup - Always run field detector from XML, overriding Frappe default company
- Convert HTML item descriptions to plain text using html2text before writing to PEPPOL XML, preserving paragraph breaks - Add no_copy to edocument and edocument_status fields on Sales Invoice and Purchase Invoice to prevent copying when duplicating invoices
…y-and-tax-template-guess fix: handle negative qty, use tax templates, and fix company detection
…-no-copy Fix/html description and no copy
Preview now renders in an iframe to prevent PEPPOL stylesheet from clashing with ERPNext desk CSS. Parser negates qty and amount for credit notes since PEPPOL uses positive values but ERPNext expects negative on return invoices.
…solation fix: isolate preview CSS in iframe and negate credit note quantities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.