Skip to content

Remove support for sx from SubNav components - #6694

Merged
liuliu-dev merged 19 commits into
mainfrom
liuliu/remove-sx-from-text-and-other-components
Sep 22, 2025
Merged

liuliu-dev merged 19 commits into
mainfrom
liuliu/remove-sx-from-text-and-other-components

Conversation

@liuliu-dev

@liuliu-dev liuliu-dev commented Aug 29, 2025 •

Copy link
Copy Markdown
Contributor

Remove sx in stories and docs for the SubNav and Textarea component.
Closes #5817

Screenshot 2025-09-12 at 3 33 43 PM

@changeset-bot

changeset-bot Bot commented Aug 29, 2025 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9418d2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 29, 2025
@github-actions
github-actions Bot temporarily deployed to storybook-preview-6694 August 29, 2025 21:10 Inactive
@liuliu-dev liuliu-dev changed the title Remove support for sx from SubNav, Text, Textarea, TextInput, TextInputWithTokens components Remove support for sx from SubNav, Textarea, TextInput, TextInputWithTokens components Aug 29, 2025
@github-actions

github-actions Bot commented Aug 29, 2025 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.75 KB (0%)
packages/react/dist/browser.umd.js 89.89 KB (0%)

@github-actions
github-actions Bot requested a deployment to storybook-preview-6694 August 29, 2025 22:04 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-6694 August 29, 2025 22:14 Inactive
@liuliu-dev liuliu-dev changed the title Remove support for sx from SubNav, Textarea, TextInput, TextInputWithTokens components Remove support for sx from SubNav and Textarea components Sep 2, 2025
@github-actions
github-actions Bot requested a deployment to storybook-preview-6694 September 2, 2025 18:11 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-6694 September 2, 2025 18:19 Inactive
@liuliu-dev liuliu-dev changed the title Remove support for sx from SubNav and Textarea components Remove support for sx from SubNav, TextInputWithTokens and Textarea components Sep 2, 2025
@github-actions
github-actions Bot temporarily deployed to storybook-preview-6694 September 12, 2025 22:54 Inactive
@github-actions github-actions Bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 12, 2025
@primer-integration

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2539

@primer-integration

Copy link
Copy Markdown

🟢 ci completed with status success.

@github-actions github-actions Bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 15, 2025
@liuliu-dev
liuliu-dev marked this pull request as ready for review September 15, 2025 22:08
@liuliu-dev
liuliu-dev requested a review from a team as a code owner September 15, 2025 22:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated sx prop support from SubNav and Textarea components as part of ongoing cleanup efforts to eliminate the sx prop from Primer React components. The changes are focused on documentation and Storybook configuration updates rather than functional code changes.

Key changes:

  • Remove sx prop documentation from component docs.json files
  • Remove sx from Storybook argTypes configuration
  • Add changeset for patch release

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
packages/react/src/Textarea/Textarea.stories.tsx Remove sx from Storybook argTypes configuration
packages/react/src/Textarea/Textarea.docs.json Remove deprecated sx prop from component documentation
packages/react/src/SubNav/SubNav.docs.json Remove deprecated sx prop from SubNav, SubNav.Link, and SubNav.Links documentation
.changeset/quick-guests-ask.md Add changeset documenting the removal of sx support

@joshblack joshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a comment around the changeset

Comment thread .changeset/quick-guests-ask.md Outdated
@@ -0,0 +1,5 @@
---
'@primer/react': patch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are just docs/stories changes I think you're okay to not include a changeset if that helps 👀

@liuliu-dev liuliu-dev added the skip changeset This change does not need a changelog label Sep 16, 2025
@github-actions
github-actions Bot requested a deployment to storybook-preview-6694 September 16, 2025 19:23 Abandoned
@github-actions
github-actions Bot temporarily deployed to storybook-preview-6694 September 16, 2025 19:31 Inactive
@liuliu-dev
liuliu-dev added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 51fa404 Sep 22, 2025
43 checks passed
@liuliu-dev
liuliu-dev deleted the liuliu/remove-sx-from-text-and-other-components branch September 22, 2025 17:43

This branch was successfully deployed

1 active and 1 inactive deployments
storybook-preview-6694 — 9418d2c0 Deployed Sep 16, 2025 by github-actions[bot]
github-pages — 9418d2c0 Deployed Sep 16, 2025 by liuliu-dev via deploy-preview #25098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants