CounterLabel, StateLabel: sync docs.json with deprecated props#8182
Draft
siddharthkp wants to merge 1 commit into
Draft
CounterLabel, StateLabel: sync docs.json with deprecated props#8182siddharthkp wants to merge 1 commit into
siddharthkp wants to merge 1 commit into
Conversation
Mark CounterLabel scheme and StateLabel variant as deprecated and document their replacements (variant, size)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
The generated props documentation for
CounterLabelandStateLabeldid not reflect deprecations that already exist in the source, so consumers had no signal to migrate:CounterLabel'sschemeandStateLabel'svariantare@deprecatedin the components, and their replacements (variantandsize) were missing from the docs entirely.Changelog
Changed
CounterLabel.schemeandStateLabel.variantare marked deprecated in the docs.New
CounterLabel.variantandStateLabel.size.Rollout strategy
Testing & Reviewing
Docs-only change. Compare each
docs.jsonagainst the props declared inCounterLabel.tsxandStateLabel.tsx.