Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-progressbar-decimal-aria.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

ProgressBar: Fix `aria-valuenow` rounding for decimal string progress values
8 changes: 8 additions & 0 deletions packages/react/src/ProgressBar/ProgressBar.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ describe('ProgressBar', () => {
expect(getByRole('progressbar')).toHaveAttribute('aria-valuenow', '50')
})

it.each([33.8, '33.8'])('rounds decimal progress %j consistently for `aria-valuenow`', progress => {
const {getByRole} = render(<ProgressBar progress={progress} aria-label="Upload test.png" />)
const progressBar = getByRole('progressbar')

expect(progressBar).toHaveAttribute('aria-valuenow', '34')
expect(progressBar.style.getPropertyValue('--progress-width')).toBe('33.8%')
})

it('applies `0` as a value for `aria-valuenow`', () => {
const {getByRole} = render(<ProgressBar progress={0} aria-valuenow={0} aria-label="Upload text.png" />)

Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/ProgressBar/ProgressBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const Item = forwardRef<HTMLSpanElement, ProgressBarItemProps>(
},
forwardRef,
) => {
const progressAsNumber = typeof progress === 'string' ? parseInt(progress, 10) : progress
const progressAsNumber = typeof progress === 'string' ? parseFloat(progress) : progress
Comment thread
UnderHear marked this conversation as resolved.

const ariaAttributes = {
'aria-valuenow':
Expand Down
Loading