Skip to content

perf(react-compiler): enable useSafeTimeout, token remove buttons, and UnderlinePanels - #8555

Open
joshblack wants to merge 5 commits into
mainfrom
joshblack/react-compiler-underline-panels
Open

joshblack wants to merge 5 commits into
mainfrom
joshblack/react-compiler-underline-panels

Conversation

@joshblack

@joshblack joshblack commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Enable React Compiler for useSafeTimeout, the private token remove button, and UnderlinePanels. This combines the small migrations from #8553, #8554, and this PR into one review without changing their implementation.

Our migration report identifies the cleanup ref access, ref handling through remaining props, and captured positional counters as the respective blockers.

Changelog

New

Changed

  • Capture the timer Set when the useSafeTimeout effect runs. Cleanup retains the same mutable Set, including timers registered after the effect.
  • Remove unused explicit ref handling from the private token remove button.
  • Keep UnderlinePanels' positional counters in a local object, preserving explicit values, independent tab and panel indexing, child order, and slot matching.
  • Remove the three compiler exclusions and add minor changesets, matching our recent compiler rollout.

Removed

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

joshblack and others added 3 commits October 15, 2026 15:42
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
@changeset-bot

changeset-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 172f24b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack
joshblack added this pull request to stack #8556 October 15, 2026 20:50
@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@joshblack
joshblack removed this pull request from stack #8556 October 15, 2026 20:55
@joshblack joshblack changed the title perf(react-compiler): enable UnderlinePanels perf(react-compiler): enable useSafeTimeout, token remove buttons, and UnderlinePanels Oct 15, 2026
@joshblack
joshblack changed the base branch from joshblack/react-compiler-token-remove-button to main October 15, 2026 20:55
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8555 October 15, 2026 21:03 Inactive
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
@primer-integration

primer-integration Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Waiting  Changes   Waiting
Passed  CI   Passed
Running  VRT   Running
Passed  Projects   Passed

@joshblack
joshblack marked this pull request as ready for review October 16, 2026 16:05
@joshblack
joshblack requested a review from a team as a code owner October 16, 2026 16:05
@joshblack
joshblack requested review from siddharthkp and a balanced review from Copilot and removed request for Copilot October 16, 2026 16:05

This branch was successfully deployed

2 active deployments
storybook-preview-8555 — 09e8fdb0 Deployed Oct 15, 2026 by github-actions[bot]
github-pages — 09e8fdb0 Deployed Oct 15, 2026 by joshblack via deploy-preview #33724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants