Skip to content

test(Avatar): cover CSS size override regression #8560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuliu-dev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test(Avatar): cover CSS size override regression #8560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d5e369
test(Avatar): cover CSS size override regression
liuliu-dev Oct 15, 2026
7dec1ff
test(vrt): add Avatar CSS size override baselines
Copilot Oct 15, 2026
e2aebcf
test(Avatar): make CSS override check assertion-only
liuliu-dev Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions e2e/components/Avatar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ const stories = [
title: 'Size',
id: 'components-avatar-features--size',
},
{
title: 'CSS Size Override Regression',
id: 'components-avatar-dev--css-size-override-regression',
expectedSize: 16,
Comment thread
liuliu-dev marked this conversation as resolved.
},
{
title: 'Size Responsive',
id: 'components-avatar-features--size-responsive',
Expand All @@ -34,8 +39,14 @@ test.describe('Avatar', () => {
},
})

// Default state
await expect(page).toHaveScreenshot(`Avatar.${story.title}.${theme}.png`)
if ('expectedSize' in story) {
const avatar = page.getByRole('img')
await expect(avatar).toHaveCSS('width', `${story.expectedSize}px`)
await expect(avatar).toHaveCSS('height', `${story.expectedSize}px`)
} else {
// Default state
await expect(page).toHaveScreenshot(`Avatar.${story.title}.${theme}.png`)
}
})
})
}
Expand Down
10 changes: 10 additions & 0 deletions packages/react/src/Avatar/Avatar.dev.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import Avatar from './Avatar'

export default {
title: 'Components/Avatar/Dev',
}

// Regression fixture for consumer style overrides. Use the size prop for supported sizing.
export const CSSSizeOverrideRegression = () => (
<Avatar alt="mona" src="https://avatars.githubusercontent.com/u/7143434?v=4" style={{width: 16, height: 16}} />
)
Loading