Skip to content

perf(Autocomplete): enable React Compiler for AutocompleteInput #8566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshblack wants to merge 1 commit into from
Draft

perf(Autocomplete): enable React Compiler for AutocompleteInput #8566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/react-compiler-autocomplete-input.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Autocomplete: Improve rendering performance with React Compiler support.
1 change: 0 additions & 1 deletion packages/react/script/react-compiler.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const files = glob
const unsupportedPatterns = [
'src/ActionMenu/ActionMenu.test.tsx',
'src/AnchoredOverlay/AnchoredOverlay.tsx',
'src/Autocomplete/AutocompleteInput.tsx',
'src/Dialog/Dialog.tsx',
'src/FilteredActionList/FilteredActionList.tsx',
'src/LabelGroup/LabelGroup.tsx',
Expand Down
13 changes: 8 additions & 5 deletions packages/react/src/Autocomplete/AutocompleteInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import TextInput from '../TextInput'
import {useMergedRefs} from '../hooks/useMergedRefs'
import type {ComponentProps} from '../utils/types'
import useSafeTimeout from '../hooks/useSafeTimeout'
import {useEffectCallback} from '../internal/hooks/useEffectCallback'

type InternalAutocompleteInputProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand Down Expand Up @@ -48,6 +49,11 @@ const AutocompleteInput = React.forwardRef(
const [highlightRemainingText, setHighlightRemainingText] = useState<boolean>(true)
const {safeSetTimeout} = useSafeTimeout()

// Read the latest highlighting state without reapplying a suggestion on Backspace keyup.
const shouldHighlightRemainingText = useEffectCallback(() => {
return highlightRemainingText
})

const handleInputFocus: FocusEventHandler<HTMLInputElement> = event => {
onFocus?.(event)
if (openOnFocus) {
Expand Down Expand Up @@ -158,8 +164,7 @@ const AutocompleteInput = React.forwardRef(

if (
isInputFocused &&
// eslint-disable-next-line react-you-might-not-need-an-effect/no-event-handler
highlightRemainingText &&
shouldHighlightRemainingText() &&
autocompleteSuggestion &&
(inputValue || isMenuDirectlyActivated)
) {
Expand All @@ -169,9 +174,7 @@ const AutocompleteInput = React.forwardRef(
inputRef.current.setSelectionRange(inputValue.length, autocompleteSuggestion.length)
}
}

// eslint-disable-next-line react-hooks/exhaustive-deps
}, [autocompleteSuggestion, inputValue, inputRef, isMenuDirectlyActivated])
}, [autocompleteSuggestion, inputValue, inputRef, isMenuDirectlyActivated, shouldHighlightRemainingText])

useEffect(() => {
setInputValue(typeof value !== 'undefined' ? value.toString() : '')
Expand Down
Loading