Skip to content

perf(Dialog): enable React Compiler - #8567

Draft
joshblack wants to merge 1 commit into
joshblack/react-compiler-autocomplete-inputfrom
joshblack/react-compiler-dialog
Draft

joshblack wants to merge 1 commit into
joshblack/react-compiler-autocomplete-inputfrom
joshblack/react-compiler-dialog

Conversation

@joshblack

Copy link
Copy Markdown
Member

This PR follows the Autocomplete compiler migration in this stack.

This PR enables React Compiler for Dialog without changing its public API. Footer autofocus no longer mutates caller-owned button props.

Focus restoration still prefers returnFocusRef. If its target disappears before the dialog closes, we now fall back to the previously focused element instead of leaving focus unrestored.

Changelog

New

Changed

  • Enable React Compiler for Dialog.
  • Restore focus to the previous element when the supplied return-focus target is no longer available.

Removed

Rollout strategy

Selected minor for the compiler rollout, consistent with the earlier entries in this stack. No consumer migration is needed.

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

@changeset-bot

changeset-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 944e7ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the staff Author is a staff member label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
@joshblack
joshblack force-pushed the joshblack/react-compiler-dialog branch from adb5bd1 to 944e7ab Compare October 20, 2026 16:12

This branch was successfully deployed

2 active (outdated) deployments
storybook-preview-8567 — adb5bd1d Deployed Oct 19, 2026 by github-actions[bot]
github-pages — adb5bd1d Deployed Oct 19, 2026 by joshblack via deploy-preview #33751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant