Repository navigation
Card: incorporate adoption feedback - #8592
Draft
liuliu-dev wants to merge 3 commits into
Draft
liuliu-dev wants to merge 3 commits into
liuliu-dev wants to merge 3 commits into
Conversation
Add optional shadows and whole-card heading actions, standardize padding, and improve custom card layouts. Record the default padding change as breaking; migration planning remains follow-up work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: acd6f39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
integration-tests: recommended
Contributor
|
Add opt-in regular padding for 16px in either layout and replace the breaking padding changeset with a minor release note. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Integration test results from github/github-ui PR: |
github-actions
Bot
added
integration-tests: failing
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to github/primer#6672.
Address Card adoption feedback. Card remains draft; alpha promotion is out of scope.
Changelog
New
shadow={false}for shadowless cards.Card.LinkandCard.Buttonfor whole-card interaction, with hover/focus indicators and independent secondary controls.padding="spacious"for 24px padding.Changed
normalpadding is now 16px in both layouts. Scale:none0px,condensed8px,normal16px,spacious24px.Removed
None.
Rollout strategy
Migration plan deferred. Consumers needing the previous 24px default must use
padding="spacious". A major changeset records this change.Testing & Reviewing
npm run build— passed.npm test -- --run packages/react/src/Card/Card.test.tsx— 60 passed.npx playwright test e2e/components/Card.test.ts --grep 'Whole-card interactions' --workers=2— 11 passed, including accessibility checks.npm run format:diff— passed. Targeted ESLint/Stylelint passed.npm run lint:css -- --ignore-pattern 'coverage/**'— passed; unfiltered CSS lint fails on generated coverage files.npm run type-check— blocked by 3 pre-existing SelectPanel/TreeView errors.Review padding/shadow in Playground and keyboard/pointer behavior in With Link, With Button, and Custom Content.