Formatting nits#54
Merged
Merged
Conversation
Replace U+2014 with comma, period, semicolon, or colon as the sentence reads best. The OpenAPI description for discardEmailContent gets the most visible fix, since that text is rendered into generated SDK docstrings and CLI --help output. None of the affected strings change meaning or break parsing; the contract.test.ts unicode-subject fixture is intentionally left alone. Generated files will follow in the next commit (regenerate from the updated spec).
Picks up the discardEmailContent description rewrite from the previous commit so the JSDoc, Python docstring, Go comment, and CLI --help output stop carrying an em dash.
Greptile SummaryThis PR removes all U+2014 em dashes from prose across the repository, replacing them with commas, periods, semicolons, or colons as appropriate. The SDKs are then regenerated so every generated artifact stays in sync with the cleaned source.
Confidence Score: 5/5Safe to merge — every change is a punctuation substitution in a comment, docstring, or description string with no effect on runtime behaviour. All 18 files touch only prose inside comments, JSDoc, docstrings, or static metadata. No logic, type signatures, schemas, or test assertions are altered. Generated artifacts are consistently regenerated from the cleaned source. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Regenerate SDKs from updated spec" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@primitivedotdev/sdknpm description, the repo's CLAUDE.md, and a couple of test comments.discardEmailContentdescription inopenapi/primitive-api.yaml, which is rendered into JSDoc, the Python docstring, the Go method comment, and the CLI--helpoutput forprimitive emails:discard-email-content.Notes
sdk-node/tests/contract/contract.test.ts(Resume from ...) deliberately exercises non-ASCII handling in subject lines.sdk-python/src/primitive/api/client.pyare emitted by the openapi-python-client template upstream, not under our control without forking the template. They will not show up in any user-facing description we ship.Test plan
make node-check-generatedcleanmake python-check-generatedcleanmake go-check-generatedclean