Skip to content

fix(site): fix pricing page json-ld#7781

Merged
mhartington merged 1 commit intomainfrom
pricing-page-fix
Apr 7, 2026
Merged

fix(site): fix pricing page json-ld#7781
mhartington merged 1 commit intomainfrom
pricing-page-fix

Conversation

@mhartington
Copy link
Copy Markdown
Member

@mhartington mhartington commented Apr 7, 2026

Summary by CodeRabbit

  • Refactor
    • Simplified pricing page metadata configuration and removed pricing-specific structured data generation.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blog Ready Ready Preview, Comment Apr 7, 2026 4:53pm
docs Ready Ready Preview, Comment Apr 7, 2026 4:53pm
eclipse Ready Ready Preview, Comment Apr 7, 2026 4:53pm
site Ready Ready Preview, Comment Apr 7, 2026 4:53pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6c665e04-1ff7-48de-aeab-9554069b1351

📥 Commits

Reviewing files that changed from the base of the PR and between 73b5be5 and 5cff624.

📒 Files selected for processing (2)
  • apps/site/src/app/pricing/page.tsx
  • apps/site/src/lib/structured-data.ts
💤 Files with no reviewable changes (1)
  • apps/site/src/lib/structured-data.ts

Walkthrough

This pull request removes pricing-specific structured data generation and consolidates metadata handling. It eliminates the createPricingStructuredData function and replaces the manual metadata object in the pricing page with a unified createPageMetadata() helper call, simplifying the page configuration approach.

Changes

Cohort / File(s) Summary
Pricing Page Metadata Consolidation
apps/site/src/app/pricing/page.tsx
Removed JsonLd, createPricingStructuredData imports and render logic. Replaced manual metadata: Metadata object (with alternates.canonical, openGraph, twitter fields) with createPageMetadata() call using title, description, path: "/pricing", and ogImage parameters.
Structured Data Utility Cleanup
apps/site/src/lib/structured-data.ts
Removed exported createPricingStructuredData() function and its local PricingTier type definition that generated Schema.org @graph JSON-LD for pricing tiers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: removal of JSON-LD structured data generation from the pricing page and migration to a centralized metadata helper.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@argos-ci
Copy link
Copy Markdown

argos-ci bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Apr 7, 2026, 4:59 PM

@mhartington mhartington merged commit daca911 into main Apr 7, 2026
18 checks passed
@mhartington mhartington deleted the pricing-page-fix branch April 7, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants