fix: use cross-zone links for footer#7792
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe footer component refactor removes URL-based external link detection and replaces it with explicit Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/ui/src/data/footer.ts (1)
5-147:⚠️ Potential issue | 🟠 MajorMark off-domain footer links as explicit external.
After moving to explicit external flags in
packages/ui/src/components/footer.tsx, these footer entries still have noexternal: true, so they won’t be treated as external links anymore (prisma-status.com,datadx.io,trust.prisma.io).Suggested patch
{ _type: "footerLinkType", title: "Platform status", url: "https://www.prisma-status.com", + external: true, }, @@ { _type: "footerLinkType", title: "Data DX", url: "https://www.datadx.io/", + external: true, }, @@ { title: "Security & Compliance", url: "https://trust.prisma.io/", + external: true, },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/ui/src/data/footer.ts` around lines 5 - 147, Some footer link objects (the footerColumnType/link objects) pointing to off-domain URLs (e.g., "https://www.prisma-status.com", "https://www.datadx.io/", "https://trust.prisma.io" and similar) are missing the explicit external flag used by the new footer rendering; update each link object and any top-level column objects that point to external domains to include external: true. Locate the link objects in the footer data (entries with _type: "footerLinkType", "_type: "footerDropdownType" links, and top-level column objects with url fields) and add external: true to those entries whose url host is not prisma.io. Ensure only true is added (don't change internal links).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/ui/src/data/footer.ts`:
- Around line 5-147: Some footer link objects (the footerColumnType/link
objects) pointing to off-domain URLs (e.g., "https://www.prisma-status.com",
"https://www.datadx.io/", "https://trust.prisma.io" and similar) are missing the
explicit external flag used by the new footer rendering; update each link object
and any top-level column objects that point to external domains to include
external: true. Locate the link objects in the footer data (entries with _type:
"footerLinkType", "_type: "footerDropdownType" links, and top-level column
objects with url fields) and add external: true to those entries whose url host
is not prisma.io. Ensure only true is added (don't change internal links).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2229d8fd-11a7-4824-b692-b4ff6fa0b76f
📒 Files selected for processing (2)
packages/ui/src/components/footer.tsxpackages/ui/src/data/footer.ts
Summary by CodeRabbit
Release Notes