Skip to content

fix: use cross-zone links for footer#7792

Merged
mhartington merged 1 commit intomainfrom
footer-links
Apr 10, 2026
Merged

fix: use cross-zone links for footer#7792
mhartington merged 1 commit intomainfrom
footer-links

Conversation

@mhartington
Copy link
Copy Markdown
Member

@mhartington mhartington commented Apr 10, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved external link handling in footer navigation to ensure external links properly open in new tabs with appropriate security attributes.
    • Updated footer links to use absolute URLs for improved navigation reliability.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blog Ready Ready Preview, Comment Apr 10, 2026 3:20pm
docs Ready Ready Preview, Comment Apr 10, 2026 3:20pm
eclipse Ready Ready Preview, Comment Apr 10, 2026 3:20pm
site Ready Ready Preview, Comment Apr 10, 2026 3:20pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

Walkthrough

The footer component refactor removes URL-based external link detection and replaces it with explicit external boolean flags in the data structure. Footer URLs are migrated from relative paths to absolute Prisma domain URLs. Component-level changes adjust anchor attributes (target, rel) based on the explicit external flag.

Changes

Cohort / File(s) Summary
Footer Component Logic
packages/ui/src/components/footer.tsx
Removed isAbsoluteUrl import and changed external link detection from URL absoluteness to explicit external boolean property. Updated dropdown link type to accept optional external?: boolean. Adjusted anchor target attribute to _blank only when external, and rel attribute to "noopener noreferrer" only for external links.
Footer Data URLs
packages/ui/src/data/footer.ts
Migrated footer column and link URLs from relative paths (e.g., /product, /docs, /contact, /pricing, /terms) to absolute https://prisma.io/... URLs across multiple entries.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: use cross-zone links for footer' clearly identifies the main change: converting footer links from relative internal paths to absolute cross-zone URLs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@argos-ci
Copy link
Copy Markdown

argos-ci bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Apr 10, 2026, 3:29 PM

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/ui/src/data/footer.ts (1)

5-147: ⚠️ Potential issue | 🟠 Major

Mark off-domain footer links as explicit external.

After moving to explicit external flags in packages/ui/src/components/footer.tsx, these footer entries still have no external: true, so they won’t be treated as external links anymore (prisma-status.com, datadx.io, trust.prisma.io).

Suggested patch
       {
         _type: "footerLinkType",
         title: "Platform status",
         url: "https://www.prisma-status.com",
+        external: true,
       },
@@
       {
         _type: "footerLinkType",
         title: "Data DX",
         url: "https://www.datadx.io/",
+        external: true,
       },
@@
           {
             title: "Security & Compliance",
             url: "https://trust.prisma.io/",
+            external: true,
           },
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/ui/src/data/footer.ts` around lines 5 - 147, Some footer link
objects (the footerColumnType/link objects) pointing to off-domain URLs (e.g.,
"https://www.prisma-status.com", "https://www.datadx.io/",
"https://trust.prisma.io" and similar) are missing the explicit external flag
used by the new footer rendering; update each link object and any top-level
column objects that point to external domains to include external: true. Locate
the link objects in the footer data (entries with _type: "footerLinkType",
"_type: "footerDropdownType" links, and top-level column objects with url
fields) and add external: true to those entries whose url host is not prisma.io.
Ensure only true is added (don't change internal links).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@packages/ui/src/data/footer.ts`:
- Around line 5-147: Some footer link objects (the footerColumnType/link
objects) pointing to off-domain URLs (e.g., "https://www.prisma-status.com",
"https://www.datadx.io/", "https://trust.prisma.io" and similar) are missing the
explicit external flag used by the new footer rendering; update each link object
and any top-level column objects that point to external domains to include
external: true. Locate the link objects in the footer data (entries with _type:
"footerLinkType", "_type: "footerDropdownType" links, and top-level column
objects with url fields) and add external: true to those entries whose url host
is not prisma.io. Ensure only true is added (don't change internal links).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2229d8fd-11a7-4824-b692-b4ff6fa0b76f

📥 Commits

Reviewing files that changed from the base of the PR and between 35ae709 and e5f093e.

📒 Files selected for processing (2)
  • packages/ui/src/components/footer.tsx
  • packages/ui/src/data/footer.ts

@mhartington mhartington merged commit af39c82 into main Apr 10, 2026
18 checks passed
@mhartington mhartington deleted the footer-links branch April 10, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant