Skip to content

Remove canvas style attribute update when changing font weight #8733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davepagurek wants to merge 1 commit into
base: dev-2.0
Choose a base branch
from
+0 −7
Open

Remove canvas style attribute update when changing font weight #8733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/type/textCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,13 +1587,6 @@ function textCore(p5, fn) {
if (typeof weight === 'number') {
this.states.setValue('fontWeight', weight);
this._applyTextProperties();

// Safari works without weight set in the canvas style attribute, and actually
// has buggy behavior if it is present, using the wrong weight when drawing
// multiple times with different weights
if (!p5.prototype._isSafari()) {
this._setCanvasStyleProperty('font-variation-settings', `"wght" ${weight}`);
}
return;
}
// the getter
Expand Down
Loading