-
Notifications
You must be signed in to change notification settings - Fork 5
Model diagram in Getting started section #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
sunirmehta
commented
Sep 30, 2019

tdawes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite right - actions update the store, not the model.
|
Is there any reason that the diagram is a triangular rather than a diamond/circle? It feels like it's suggesting that |
|
Also perhaps we should change |
|
Yeah looks better to me. Still not sure whether "updates" is better than "patches" - what do you think? We should also change It might also be better to make sure it's obvious that the important "cycle" is I'm also a little unsure that we're being clear enough:
This is an example of how redux is sometimes explained: |
|
@tdawes @sunirmehta is this resolved? |
|
Mostly looks good to me, except I think you want the dispatch arrow to be the other way around. But probably need @tdawes to confirm. It would be worth adding this soon given one of our users has already expressed confusion about the model, and maybe this would help at least a little bit. |



