Open
Conversation
|
💩 Code linting failed, use |
Coverage Report
Summary
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
grigoriev-semyon
requested changes
Aug 4, 2023
|
💩 Code linting failed, use |
grigoriev-semyon
requested changes
Aug 4, 2023
Member
grigoriev-semyon
left a comment
There was a problem hiding this comment.
тесты норм
добавь lazy и норм
grigoriev-semyon
previously approved these changes
Aug 4, 2023
Member
|
@dyakovri посмотри тоже пж |
dyakovri
requested changes
Aug 6, 2023
Comment on lines
+128
to
+133
| for _user in db_delete_users: | ||
| for print_fact in _user.print_facts: | ||
| db.session.delete(print_fact) | ||
| for files in _user.files: | ||
| db.session.delete(files) | ||
| db.session.delete(_user) |
Member
There was a problem hiding this comment.
Мы так просрем всю статистику. Так делать нельзя
Member
There was a problem hiding this comment.
Софт делит на юзера надо сделать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
Теперь при обновлении пользователей, если последний не был указан в запросе, то он удаляется из базы.
Реализации
Реализована проверка на то, надо ли удалять пользователя или оставлять его.
Детали
Происходит удаление пользователей с теми
id, которые не были указаны в начальном запросе.Check-List