feat: #14 in white, not just a name - #42
Merged
Merged
Conversation
"we should use team color and names not just names — that would help with detection (ie: #14 in white team not #14 on black team)." Correct, and the column was already there: `jersey_color` has been on the athlete row since the first migration, and nothing has ever written it or shown it. So the picker offered a name — the one attribute a detector cannot help you match against — while the two things a parent actually points with, the number and the shirt, went unrecorded. Both teams have a 14 and on a school court they are regularly on screen together. Identity is now collected where the user is already looking at the child, in the picker itself, rather than in a separate "Add an athlete" form they would have to find first: name, number, shirt colour, team, all optional. Quick-identify no longer produces "My athlete" when the user told us who it was. Everywhere an athlete is named now reads "Fred #14 in white (Triton)", colour before team because colour is the part visible in the footage. The appearance matcher already separates the teams — a shirt signature is how it refuses the black team's 14 — so this makes the thing it keys on visible to the person judging its suggestions, rather than adding a second mechanism. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
# Conflicts: # apps/web/src/actions.ts # apps/web/src/client/identify.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right, and the column was already there.
jersey_colorhas been on the athlete row since the first migration and nothing has ever written or shown it. So the picker could only offer a name — the one attribute a detector cannot help you match against — while the two things a parent actually points with, the number and the shirt, went unrecorded.Changes
Fred #14 in white (Triton)— colour before team, because colour is what is visible in the footage./candidatesreturnsteamandjerseyColorso the picker can show them.On "would help with detection"
Worth being precise: the appearance matcher added in #35 already separates the teams — a shirt-colour signature is exactly how it refuses the black team's 14, and measurably so (colour alone matched 661 of 1152 tracks; colour plus continuity, 14). This PR makes the thing it already keys on visible to the person judging its suggestions, rather than adding a second mechanism that could disagree with the first.
4 new tests. 575 pass, 8 skipped. Lint and build clean.
2 of 3 from the same report; ball detection recall is next.
🤖 Generated with Claude Code