Open
Conversation
humanitas03
reviewed
May 24, 2022
user/serializer.py
Outdated
Comment on lines
28
to
30
| class SignupRequestBodySerializer(UserSerializer, UserProfileSerializer): | ||
| def __init__(self): | ||
| super(SignupRequestBodySerializer, self).__init__() |
Contributor
There was a problem hiding this comment.
갠적으로 모델 시리얼라이저 를 다중상속 하지말고, 번거롭더라도 request json필드 그대로 시리얼라이저 그대로 가는걸 선호합니다만,
궁금한게 이렇게 시리얼라이저 적용하고나서 생성되는 Swagger 문서에 RequestBody의 필드가 View 로직에서 request.data 로 받는 필드와 정확하게 매칭이 되나요?
Contributor
Author
There was a problem hiding this comment.
시리얼라이저 구현 방식을 바꿔봤어요. 이렇게 했더니 기존 모델에 구애받지 않고 작성할 수 있더라구요
또 이렇게 하니까 request.data로 받는 필드와 매칭이 되더라구요~
humanitas03
reviewed
May 27, 2022
ginza/settings/local.py
Outdated
Comment on lines
136
to
138
| CORS_ALLOW_ALL_ORIGINS = True | ||
|
|
||
| CORS_ALLOW_CREDENTIALS = True |
Contributor
There was a problem hiding this comment.
CORS관련 설정이 추가된 사유가 뭘까요?
Contributor
There was a problem hiding this comment.
이거 중간에 카카오 인증쪽 호스트 접속 하는 과정에서 cors 때문에 추가하신듯 한데,
React에서 proxy 설정을 지정하면 이슈가 없을듯 해서 일단 이부분은 원복 부탁드릴께요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
PR 개요
주요 작업사항