Skip to content

Update README and docs: fix stale SQLite/NextAuth references, sync structure - #59

Merged
projectamazonph merged 3 commits into
mainfrom
claude/fix-remaining-issues
Aug 3, 2026
Merged

Update README and docs: fix stale SQLite/NextAuth references, sync structure#59
projectamazonph merged 3 commits into
mainfrom
claude/fix-remaining-issues

Conversation

@projectamazonph

@projectamazonph projectamazonph commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

The database has been Postgres (via @prisma/adapter-neon) since the B-04 audit fix, but README.md, AGENTS.md, and several docs/ files still described SQLite as current — including a literal provider = "sqlite" schema snippet and file:./dev.db env examples that would produce a broken setup if followed today. Fixed all current-state references. Left docs/AUDIT-FOLLOWUPS.md's historical finding and docs/HANDOFF.md's dated 2026-07-20 snapshot alone, since both are accurate records of a specific point in time, not claims about the app today.

Also fixed env var names to match .env.example / src/lib/auth.ts (AUTH_SECRET, not NEXTAUTH_SECRET/NEXTAUTH_URL — this repo runs NextAuth v5's Auth.js env var convention and doesn't need a URL var at all).

Other fixes:

  • README's project structure tree still showed core/ as a flat 3-file module and CreateCampaignWizard.tsx as a top-level file; updated to match the real core/engine/ + core/slices/ split and the wizard/ subdirectory with per-ad-type steps.
  • README's Tech Stack table was missing Astryx (153 components, actively used across ~40 files) entirely.
  • README's pre-built-campaign table listed campaign docs: reconcile README and codegraph with the actual static simulator #3's targeting mode as "Video creative" — that's the ad format, not targetingMode (which is actually 'Keyword'); corrected.
  • README claimed "8 slices" for the Zustand store; it's 8 core slices + 7 feature slices (15 total), per CLAUDE.md.
  • docs/TECH-SPECS.md's file-statistics table was stale in both directory shape and line counts (e.g. citing a single 600-line engine.ts that hasn't existed since the engine/ split); refreshed with real counts and dated the snapshot so future staleness is at least self-documenting.
  • Linked the new CHANGELOG.md and existing-but-unlinked docs/DEPLOYMENT.md from README's Documentation section.
  • CLAUDE.md: documented the new .claude//.agents//.codex/ ECC bundle (feat: add Amazon-ad-console ECC bundle #56) and flagged that its auto-generated skill file contains at least one inaccurate claim (invented camelCase filename examples that don't match this repo's real PascalCase-components / lowercase-engine-modules convention) — CLAUDE.md remains the authoritative source when they disagree.

Test plan

  • npx tsc --noEmit
  • npx vitest run (668 tests passing — docs-only change, included as a sanity check)
  • Cross-checked every changed claim against the actual source (prisma/schema.prisma, .env.example, src/lib/auth.ts, src/lib/prisma.ts, store.ts, wc -l on the real file tree) rather than guessing

Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated setup and architecture guides to reflect PostgreSQL persistence.
    • Revised authentication configuration, environment variables, deployment guidance, and troubleshooting instructions.
    • Updated technical specifications, feature documentation, and project structure details.
    • Documented agent-tooling directories and clarified authoritative project guidance.
    • Added links to deployment and changelog documentation.

…ructure

The database has been Postgres (via @prisma/adapter-neon) since the
B-04 audit fix, but README.md, AGENTS.md, and several docs/ files
still described SQLite as current — including a literal
`provider = "sqlite"` schema snippet and `file:./dev.db` env examples
that would produce a broken setup if followed today. Fixed all
current-state references (left docs/AUDIT-FOLLOWUPS.md's historical
finding and docs/HANDOFF.md's dated 2026-07-20 snapshot alone, since
both are accurate records of a specific point in time, not claims
about the app today).

Also fixed the env var names to match .env.example / src/lib/auth.ts
(AUTH_SECRET, not NEXTAUTH_SECRET/NEXTAUTH_URL — this repo runs
NextAuth v5's Auth.js env var convention and doesn't need a URL var
at all).

Other fixes:
- README's project structure tree still showed core/ as a flat
  3-file module and CreateCampaignWizard.tsx as a top-level file;
  updated to match the real core/engine + core/slices split and the
  wizard/ subdirectory with per-ad-type steps.
- README's Tech Stack table was missing Astryx (153 components,
  actively used across ~40 files) entirely.
- README's pre-built-campaign table listed campaign #3's targeting
  mode as "Video creative" — that's the ad format, not targetingMode
  (which is actually 'Keyword'); corrected.
- README claimed "8 slices" for the Zustand store; it's 8 core slices
  + 7 feature slices (15 total), per CLAUDE.md.
- docs/TECH-SPECS.md's file-statistics table was stale in both
  directory shape and line counts (e.g. citing a single 600-line
  engine.ts that hasn't existed since the engine/ split); refreshed
  with real counts and dated the snapshot so future staleness is at
  least self-documenting.
- Linked the new CHANGELOG.md and existing-but-unlinked
  docs/DEPLOYMENT.md from README's Documentation section.
- CLAUDE.md: documented the new .claude/.agents/.codex ECC bundle
  (PR #56) and flagged that its auto-generated skill file contains at
  least one inaccurate claim (invented camelCase filename examples
  that don't match this repo's real PascalCase-components /
  lowercase-engine-modules convention) — CLAUDE.md remains the
  authoritative source when they disagree.
Copilot AI review requested due to automatic review settings August 3, 2026 16:38
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
amazon-ad-console Ready Ready Preview Aug 3, 2026 4:47pm

@ecc-tools

ecc-tools Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@projectamazonph, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4fbcf21e-7360-4ed6-8a95-864a4d05545f

📥 Commits

Reviewing files that changed from the base of the PR and between ef0d2a4 and edf96f8.

📒 Files selected for processing (3)
  • README.md
  • docs/AUTH.md
  • docs/TECH-SPECS.md
📝 Walkthrough

Walkthrough

Documentation now describes Prisma 7 with Postgres through the Neon adapter, updated authentication variables, current project structure, deployment links, and agent-tooling guidance.

Changes

Documentation refresh

Layer / File(s) Summary
Platform and persistence documentation
AGENTS.md, README.md, docs/ARCHITECTURE.md, docs/FEATURES.md, docs/TECH-SPECS.md
Documentation now describes Prisma 7 with Postgres, the Neon adapter, and token-based UI styling.
Authentication configuration and operations
docs/AUTH.md, docs/ARCHITECTURE.md, docs/TECH-SPECS.md
Authentication setup, deployment, troubleshooting, and environment examples now use AUTH_SECRET and Postgres.
Repository structure and tooling documentation
README.md, CLAUDE.md, docs/TECH-SPECS.md
Documentation now reflects the current project structure, generated agent-tooling directories, file statistics, and related links.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the documentation updates, including stale SQLite and NextAuth references and project structure synchronization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-remaining-issues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The changes are documentation-only and largely verified against the repo, with only a minor README structure-sync nit remaining.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Updates repository documentation to reflect the current production reality (Postgres via Prisma Neon adapter + NextAuth v5/Auth.js env conventions) and to realign README/docs with the actual codebase structure and tooling.

Changes:

  • Replaces stale SQLite / NEXTAUTH_* setup guidance with Postgres + AUTH_SECRET conventions across README and docs.
  • Refreshes README structure/stack descriptions (engine split, wizard folder, Astryx components, slice counts) and links to additional docs.
  • Updates docs/TECH-SPECS.md with a dated file-statistics snapshot and modern Prisma driver-adapter notes.
File summaries
File Description
README.md Corrects onboarding/architecture claims (stack, structure, docs links) to match current codebase reality.
docs/TECH-SPECS.md Updates Prisma provider/env guidance and refreshes file-statistics snapshot with clearer context.
docs/FEATURES.md Updates auth feature section to reflect Postgres via @prisma/adapter-neon.
docs/AUTH.md Updates auth + env var documentation to current Auth.js conventions and Postgres-only reality.
docs/ARCHITECTURE.md Updates server-side data flow + env vars to match Prisma Neon adapter + Postgres.
CLAUDE.md Documents ECC bundle presence and clarifies authoritative guidance vs generated skill claims.
AGENTS.md Updates stack summary (Postgres via Neon; Astryx/tokens styling) to match current repo setup.
Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread README.md Outdated
Copilot review flagged that these two backward-compat re-export files
(export * from './core/types' / './core/scenarios') were dropped when
the tree was resynced — they still exist and are real navigation
points, unlike the engine.ts single-file that was correctly removed.
@ecc-tools

ecc-tools Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/AUTH.md`:
- Around line 297-301: Update the Prisma documentation sentence in AUTH.md to
state that prisma/schema.prisma declares the PostgreSQL datasource provider,
while runtime adapter wiring is configured separately in src/lib/prisma.ts.
Avoid implying that the schema itself configures `@prisma/adapter-neon`.
- Around line 64-76: The Prisma setup dependencies are incomplete and
inconsistent across the documentation. In docs/AUTH.md, update the initial
install command to include `@prisma/adapter-neon` and `@neondatabase/serverless`
alongside prisma and `@prisma/client`; in docs/TECH-SPECS.md, update the
dependency table and runtime dependency count to include both Neon packages.
- Around line 332-334: Update docs/AUTH.md lines 332-334 to identify “migrate
dev” as local-development troubleshooting only and direct production users to
“migrate deploy”; update docs/TECH-SPECS.md lines 102-107 to label both “migrate
dev” and “db push” as development-only, then add “migrate deploy” for production
deployments.

In `@README.md`:
- Around line 241-243: Update the documentation tree in README.md to include
docs/DEPLOYMENT.md and docs/AUDIT-FOLLOWUPS.md alongside the existing entries,
keeping it consistent with the documentation index links.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0635ed75-6a94-4bb5-82ef-8cab62249b40

📥 Commits

Reviewing files that changed from the base of the PR and between 1f7f6f6 and ef0d2a4.

📒 Files selected for processing (7)
  • AGENTS.md
  • CLAUDE.md
  • README.md
  • docs/ARCHITECTURE.md
  • docs/AUTH.md
  • docs/FEATURES.md
  • docs/TECH-SPECS.md

Comment thread docs/AUTH.md
Comment thread docs/AUTH.md Outdated
Comment thread docs/AUTH.md
Comment thread README.md
…eploy

- docs/AUTH.md: clarified that prisma/schema.prisma only declares the
  postgresql provider — the DATABASE_URL/adapter-neon runtime wiring
  lives in prisma.config.ts / src/lib/prisma.ts, not the schema.
- docs/AUTH.md + docs/TECH-SPECS.md: added the two Neon packages
  (@prisma/adapter-neon, @neondatabase/serverless) to the install
  command and dependency table; also refreshed the dependency table's
  stale versions (^5.0.0 Prisma, ^11.0.0 motion, etc. — actual
  package.json has 7.8.0/12.42.2) and added the Astryx/phosphor-icons/
  dotenv packages that were missing from it entirely. Dropped the
  "total runtime dependency count" line in favor of pointing at
  package.json, since a hardcoded count is exactly the kind of number
  that goes stale silently.
- docs/AUTH.md + docs/TECH-SPECS.md: distinguished `migrate dev`
  (local development) from `migrate deploy` (production/CI — doesn't
  prompt interactively).
- README.md: added docs/DEPLOYMENT.md and docs/AUDIT-FOLLOWUPS.md to
  the project structure tree, matching the Documentation section's
  links.
@ecc-tools

ecc-tools Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@projectamazonph
projectamazonph merged commit c373b84 into main Aug 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants