🛡️ Sentinel: Improving Authentication Rate Limiting

[projectamazonph]

🛡️ Sentinel: [HIGH] Improve Authentication Rate Limiting

• 🚨 Severity: HIGH
• 💡 Vulnerability: Prior to this patch, authentication endpoints (signInAction and signUpAction) were only rate-limited on target lowercase email keys. This allowed single-IP credential stuffing attacks targeting distinct emails concurrently, circumventing the email rate limiter and risking DoS via resource starvation.
• 🎯 Impact: Malicious actors could perform large-scale brute-force and credential stuffing attacks on various user accounts from a single source IP, and exhaust server resources through password hashing operations.
• 🔧 Fix: Implemented dual rate-limiting combining target-based keys (lowercase emails) with IP-based keys (retrieved from x-forwarded-for / x-real-ip headers via Next's async headers()). Added unit tests for rate-limit.ts bringing code coverage to 100%. Mocked next/headers' headers() in tests to prevent runtime errors.
• ✅ Verification: Verified by running all unit tests successfully with 100% test coverage on rate-limit.ts and passing 217 tests overall.

---

PR created automatically by Jules for task 6426460997782455538 started by @projectamazonph

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

Warning

Review limit reached

@projectamazonph, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 286cad22-9880-42c5-b27d-0909ed64daff

📥 Commits

Reviewing files that changed from the base of the PR and between dabee94 and b5f0b23.

📒 Files selected for processing (7)

• .jules/sentinel.md
• src/__tests__/setup.ts
• src/app/actions/__tests__/auth-actions.test.ts
• src/app/actions/__tests__/progress-actions.test.ts
• src/app/actions/__tests__/tool-actions.test.ts
• src/app/actions/auth.ts
• src/lib/__tests__/rate-limit.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/sentinel-dual-rate-limiting-6426460997782455538

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}