Skip to content

(bug) Fix drift-detection-manager RBAC in agentless mode #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
Feb 25, 2026
Merged

(bug) Fix drift-detection-manager RBAC in agentless mode #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ OS ?= $(shell uname -s)
OS := $(shell echo $(OS) | tr '[:upper:]' '[:lower:]')
K8S_LATEST_VER ?= $(shell curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
export CONTROLLER_IMG ?= $(REGISTRY)/$(IMAGE_NAME)
TAG ?= v1.5.0
TAG ?= main

.PHONY: all
all: build
Expand Down
2 changes: 1 addition & 1 deletion config/default/manager_auth_proxy_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
- --shard-key=
- --capi-onboard-annotation=
- "--v=5"
- "--version=v1.5.0"
- "--version=main"
- "--agent-in-mgmt-cluster=false"
env:
- name: GOMEMLIMIT
Expand Down
4 changes: 2 additions & 2 deletions config/default/manager_image_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ spec:
template:
spec:
initContainers:
- image: docker.io/projectsveltos/addon-controller:v1.5.0
- image: docker.io/projectsveltos/addon-controller:main
name: initialization
containers:
- image: docker.io/projectsveltos/addon-controller:v1.5.0
- image: docker.io/projectsveltos/addon-controller:main
name: controller
6 changes: 3 additions & 3 deletions manifest/deployment-agentless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
- --shard-key=
- --capi-onboard-annotation=
- --v=5
- --version=v1.5.0
- --version=main
- --agent-in-mgmt-cluster=true
command:
- /manager
Expand All @@ -39,7 +39,7 @@ spec:
valueFrom:
resourceFieldRef:
resource: limits.cpu
image: docker.io/projectsveltos/addon-controller:v1.5.0
image: docker.io/projectsveltos/addon-controller:main
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down Expand Up @@ -85,7 +85,7 @@ spec:
env:
- name: IS_INITIALIZATION
value: "true"
image: docker.io/projectsveltos/addon-controller:v1.5.0
image: docker.io/projectsveltos/addon-controller:main
name: initialization
securityContext:
runAsNonRoot: true
Expand Down
6 changes: 3 additions & 3 deletions manifest/deployment-shard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
- --shard-key={{.SHARD}}
- --capi-onboard-annotation=
- --v=5
- --version=v1.5.0
- --version=main
- --agent-in-mgmt-cluster=false
command:
- /manager
Expand All @@ -39,7 +39,7 @@ spec:
valueFrom:
resourceFieldRef:
resource: limits.cpu
image: docker.io/projectsveltos/addon-controller:v1.5.0
image: docker.io/projectsveltos/addon-controller:main
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down Expand Up @@ -85,7 +85,7 @@ spec:
env:
- name: IS_INITIALIZATION
value: "true"
image: docker.io/projectsveltos/addon-controller:v1.5.0
image: docker.io/projectsveltos/addon-controller:main
name: initialization
securityContext:
runAsNonRoot: true
Expand Down
6 changes: 3 additions & 3 deletions manifest/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7918,7 +7918,7 @@ spec:
- --shard-key=
- --capi-onboard-annotation=
- --v=5
- --version=v1.5.0
- --version=main
- --agent-in-mgmt-cluster=false
command:
- /manager
Expand All @@ -7931,7 +7931,7 @@ spec:
valueFrom:
resourceFieldRef:
resource: limits.cpu
image: docker.io/projectsveltos/addon-controller:v1.5.0
image: docker.io/projectsveltos/addon-controller:main
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down Expand Up @@ -7977,7 +7977,7 @@ spec:
env:
- name: IS_INITIALIZATION
value: "true"
image: docker.io/projectsveltos/addon-controller:v1.5.0
image: docker.io/projectsveltos/addon-controller:main
name: initialization
securityContext:
runAsNonRoot: true
Expand Down
4 changes: 2 additions & 2 deletions pkg/drift-detection/drift-detection-manager-in-mgmt-cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ spec:
- --cluster-type=
- --current-cluster=management-cluster
- --run-mode=do-not-send-updates
- --version=v1.5.0
- --version=main
command:
- /manager
image: docker.io/projectsveltos/drift-detection-manager@sha256:47cb5531adfe14d4be2e02f9d93da04c775caea5f67ab4e978ed5667fcb5ffe5
image: docker.io/projectsveltos/drift-detection-manager@sha256:bc677632bc882102535e10b52454ef595fbb6efe7bb37b14b870c4a3a4fd3d82
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down
4 changes: 2 additions & 2 deletions pkg/drift-detection/drift-detection-manager-in-mgmt-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ spec:
- --cluster-type=
- --current-cluster=management-cluster
- --run-mode=do-not-send-updates
- --version=v1.5.0
- --version=main
command:
- /manager
image: docker.io/projectsveltos/drift-detection-manager@sha256:47cb5531adfe14d4be2e02f9d93da04c775caea5f67ab4e978ed5667fcb5ffe5
image: docker.io/projectsveltos/drift-detection-manager@sha256:bc677632bc882102535e10b52454ef595fbb6efe7bb37b14b870c4a3a4fd3d82
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down
4 changes: 2 additions & 2 deletions pkg/drift-detection/drift-detection-manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ spec:
- --cluster-type=
- --current-cluster=managed-cluster
- --run-mode=do-not-send-updates
- --version=v1.5.0
- --version=main
command:
- /manager
env:
Expand All @@ -158,7 +158,7 @@ spec:
valueFrom:
resourceFieldRef:
resource: limits.cpu
image: docker.io/projectsveltos/drift-detection-manager@sha256:47cb5531adfe14d4be2e02f9d93da04c775caea5f67ab4e978ed5667fcb5ffe5
image: docker.io/projectsveltos/drift-detection-manager@sha256:bc677632bc882102535e10b52454ef595fbb6efe7bb37b14b870c4a3a4fd3d82
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down
4 changes: 2 additions & 2 deletions pkg/drift-detection/drift-detection-manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ spec:
- --cluster-type=
- --current-cluster=managed-cluster
- --run-mode=do-not-send-updates
- --version=v1.5.0
- --version=main
command:
- /manager
env:
Expand All @@ -140,7 +140,7 @@ spec:
valueFrom:
resourceFieldRef:
resource: limits.cpu
image: docker.io/projectsveltos/drift-detection-manager@sha256:47cb5531adfe14d4be2e02f9d93da04c775caea5f67ab4e978ed5667fcb5ffe5
image: docker.io/projectsveltos/drift-detection-manager@sha256:bc677632bc882102535e10b52454ef595fbb6efe7bb37b14b870c4a3a4fd3d82
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down
18 changes: 13 additions & 5 deletions test/drift-detection-mgmt_cluster_common_manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ rules:
- update
- watch
- apiGroups:
- ""
- '*'
resources:
- events
- '*'
verbs:
- create
- patch
- update
- get
- list
- watch
- apiGroups:
- authentication.k8s.io
resources:
Expand All @@ -47,6 +47,14 @@ rules:
- subjectaccessreviews
verbs:
- create
- apiGroups:
- events.k8s.io
resources:
- events
verbs:
- create
- patch
- update
- apiGroups:
- lib.projectsveltos.io
resources:
Expand Down