Add support for remote write config with syntactic sugar - #122
Merged
Merged
Conversation
Template version: main (c61b93c)
HappyTetrahedron
force-pushed
the
remotewrite-config
branch
from
September 14, 2026 12:45
be25907 to
880088a
Compare
HappyTetrahedron
force-pushed
the
remotewrite-config
branch
from
September 14, 2026 13:41
880088a to
8b82865
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
simu
requested changes
Sep 15, 2026
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
LGTM overall, except for the bug in the timeseries folding for empty lists.
Ideally, we'd also backport the empty list fix to component-openshift4-monitoring.
simu
approved these changes
Sep 15, 2026
4 tasks done
Contributor
Author
|
Backport to component-openshift4-monitoring: appuio/component-openshift4-monitoring#284 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to use the same style of remote write config as we do in
component-openshift4-monitoring, in which it is possible to specify a list of timeseries (which is then automatically folded into a regexp through component logic).It will be convenient to re-use the remote write configuration we have for openshift on our talos clusters as well.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.