Render ThanosRuler instances - #127
Merged
Merged
Conversation
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
simu
reviewed
Sep 21, 2026
simu
approved these changes
Sep 22, 2026
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
thanosRuleras an instance component, so an instance can render aThanosRulernext to its Prometheus and Alertmanager. Enabling it emits theThanosRuler, aServiceAccount, aServiceMonitorand aPrometheusRulewith a few guard alerts.I went back and forth on where this belongs. prometheus-operator installs the CRD and this component already passes
--thanos-ruler-instance-namespacesfor every instance namespace, it just never creates a ruler no logic for that in kube-prometheus. There is also kube-thanos which has a rule module but emits a plain StatefulSet with ConfigMap rule files and no PrometheusRule discovery and its last release was about four years ago. I also looked at a separate component around the Helm chart but that chart always wants either object storage or remote-write, which I do not need in my case, I only want the ruler to evaluate alerting rules and hand them to Alertmanager.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.