Skip to content

Render ThanosRuler instances - #127

Merged
mdnix merged 5 commits into
masterfrom
feat/thanos-ruler
Sep 22, 2026
Merged

mdnix merged 5 commits into
masterfrom
feat/thanos-ruler

Conversation

@mdnix

@mdnix mdnix commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds thanosRuler as an instance component, so an instance can render a ThanosRuler next to its Prometheus and Alertmanager. Enabling it emits the ThanosRuler, a ServiceAccount, a ServiceMonitor and a PrometheusRule with a few guard alerts.

I went back and forth on where this belongs. prometheus-operator installs the CRD and this component already passes --thanos-ruler-instance-namespaces for every instance namespace, it just never creates a ruler no logic for that in kube-prometheus. There is also kube-thanos which has a rule module but emits a plain StatefulSet with ConfigMap rule files and no PrometheusRule discovery and its last release was about four years ago. I also looked at a separate component around the Helm chart but that chart always wants either object storage or remote-write, which I do not need in my case, I only want the ruler to evaluate alerting rules and hand them to Alertmanager.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@mdnix
mdnix requested a review from a team as a code owner September 18, 2026 12:47
@mdnix mdnix added enhancement New feature or request bump:minor labels Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

🚀 This PR has been released as v2.19.0

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:minor

@mdnix
mdnix requested a review from a team September 18, 2026 14:56
Comment thread component/common.libsonnet Outdated
Comment thread tests/thanos.yml Outdated
@mdnix
mdnix requested a review from simu September 21, 2026 12:20

@simu simu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

Comment thread component/common.libsonnet
Comment thread component/common.libsonnet
Comment thread docs/modules/ROOT/pages/references/parameters.adoc
mdnix and others added 3 commits September 22, 2026 10:55
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
@mdnix
mdnix merged commit c7c6e46 into master Sep 22, 2026
55 checks passed
@mdnix
mdnix deleted the feat/thanos-ruler branch September 22, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump:minor enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants