Add distribution-agnostic alert-routing-discovery library - #12
Open
simu wants to merge 5 commits into
Open
Conversation
simu
force-pushed
the
feat/alert-routing-discovery
branch
2 times, most recently
from
July 28, 2026 08:08
35debb0 to
00ec536
Compare
This has been factored out from https://github.com/appuio/component-openshift4-monitoring/.
simu
force-pushed
the
feat/alert-routing-discovery
branch
from
July 28, 2026 08:45
00ec536 to
6674dc3
Compare
The inventory for the test case is copied (and slightly adapted) from component-openshift4-monitoring's `team-routing` test case.
We can always use `parameters._instance` to do the autodiscovery
patching for instantiated components which use `${_instance}` to define
their namespace.
Member
Author
|
Tested locally against APPUiO Lab via appuio/component-openshift4-monitoring#278. Verified that there's no diff in the Lab catalog when switching to this version of the alert routing discovery logic. |
simu
marked this pull request as ready for review
July 28, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been factored out from https://github.com/appuio/component-openshift4-monitoring/.
See also appuio/component-openshift4-monitoring#278
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.