Skip to content

fix: use Plawrights chroumium in CI to make tests pass #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartveneman merged 1 commit into from
Oct 12, 2026
Merged

fix: use Plawrights chroumium in CI to make tests pass #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
node-version: 24
package-manager-cache: false
- run: pnpm install --frozen-lockfile
- run: pnpm exec playwright install --with-deps chromium
- run: pnpm test

build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
cache: 'pnpm'
node-version: 24
- run: pnpm install --frozen-lockfile
- run: pnpm exec playwright install --with-deps chromium
- run: pnpm test

check:
Expand Down
4 changes: 1 addition & 3 deletions test/helpers/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ let browser: Browser | undefined

async function getBrowser(): Promise<Browser> {
if (!browser) {
// Use the CI runner's system Chrome instead of Playwright's bundled
// Chromium, so no separate `playwright install` step is needed.
browser = await chromium.launch(process.env.CI ? { channel: 'chrome' } : {})
browser = await chromium.launch()
}
return browser
}
Expand Down
Loading