Enforce curly braces in conditional statements - #386
Merged
Conversation
The style category isn't enabled in oxlintrc.json, so curly (require braces around all control statement bodies) was off by default. Turn it on explicitly and auto-fix + reformat the codebase.
Our own oxlintrc.json rules were essentially the preset already, so extend it and keep only the local differences (env, curly, and the handful of rules the preset doesn't set or sets differently). The preset pulls in the vitest plugin, whose no-conditional-in-test rule fires on our Playwright *.spec.ts files (they use test()/expect() too, but aren't vitest tests) — turn it off there via an override.
✅ Deploy Preview for projectwallace ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bartveneman
pushed a commit
that referenced
this pull request
Aug 31, 2026
Rebased on main, which now enforces oxlint's curly rule repo-wide (#386). Fixes the handful of one-line if-statements in this branch's own new code that the rule now flags. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E7X88yKZHKpehyuogXpFDT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces consistent code style by requiring curly braces around all conditional statement bodies, improving code readability and reducing potential bugs.
Summary
Updated the linting configuration to use a shared preset and enforce the
curlyrule, then applied the resulting style changes across the codebase.Key Changes
Linting Configuration:
oxlintrc.jsonby extending@projectwallace/preset-oxlintpresetcurly: "error"rule to enforce braces around all conditional blocksvitest/no-conditional-in-testes2024from env (now in preset)Code Style Updates:
ifstatements throughout the codebaseImplementation Details
if (condition) { return }instead ofif (condition) returnhttps://claude.ai/code/session_01Uvf2EU2MbXrBs95K94d8vo