fix: avoid protobuf debug reflection in native images#2251
Open
arnabnandy7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
arnabnandy7
requested review from
dhoard,
fstab,
jaydeluca and
zeitlinger
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1995.
This PR avoids GraalVM native-image failures when using the protobuf debug exposition format with native histograms. The debug output path now formats protobuf metric families through direct generated protobuf getters instead of
TextFormat.printer(), which relied on reflection unavailable in native images.Changes
PrometheusProtobufWriterImpl#toDebugString(...)to use the new formatter.Testing
mise run lint:fix./mvnw.cmd -pl prometheus-metrics-exposition-formats test -Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn./mvnw.cmd -pl prometheus-metrics-exposition-formats-shaded -am install -DskipTests -Dcoverage.skip=trueNote: Docker/Testcontainers exporter integration test was not run locally because Docker Desktop’s Linux engine was not running.