feat(core): hide the noLink magic comment in every mark mode - #523
feat(core): hide the noLink magic comment in every mark mode#523ocavue wants to merge 7 commits into
noLink magic comment in every mark mode#523Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds the ChangesMagic comment handling
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The change hides noLink metadata consistently and preserves atomic deletion and URL relinking across mark modes; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant MarkdownInput
participant walkUnlinkedURL
participant ProseMirrorDocument
participant getHiddenPredicate
participant createSnapPlugin
MarkdownInput->>walkUnlinkedURL: URL followed by noLink comment
walkUnlinkedURL->>ProseMirrorDocument: create mdPack and mdMagic
ProseMirrorDocument->>getHiddenPredicate: active mark mode
getHiddenPredicate-->>createSnapPlugin: hidden-run predicate
createSnapPlugin->>ProseMirrorDocument: adjust caret position
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 76.19% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 14 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
noLink magic comment in every mark mode
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
f0d8c9e to
7dbd8ac
Compare
a5db555 to
53a8f1e
Compare
227e4c7 to
be49687
Compare
be49687 to
b82a9a6
Compare
The
noLinkmagic comment is editor metadata, so it now renders as an always-hiddenmdMagicrun in every mark mode instead of dim source text in show mode. The hidden-run caret rules (snap, Enter relocation, backspace dissolve) now cover magic runs in focus and show mode too, so deleting into the comment removes it whole and the URL autolinks again.Summary by CodeRabbit
noLinkmagic comments through Markdown conversion and clipboard operations.