test(react): reproduce the Safari code block Enter corruption - #529
Draft
ocavue wants to merge 2 commits into
Draft
test(react): reproduce the Safari code block Enter corruption#529ocavue wants to merge 2 commits into
ocavue wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro only, no fix, driven entirely by user gestures (click, arrow keys, a plain Enter). The new
react-webkit-iosvitest project runs the test with an iPhone Safari user agent, where prosemirror-view hands every plain Enter in a code block to WebKit's native editing: the<pre>gets clone-split and the React node view leaves a rogue<br>or silently deletes the text before the caret, sotest-mac-webkitis expected to fail while the same gestures pass on desktop browsers. The other entrance (desktop Safari, IME commit then Enter within 500ms) cannot be automated because no driver can operate the OS input method; reproduce it manually, or see the fix in #522.