Open
Conversation
2 week two
18thday
commented
Jan 14, 2026
04_week/tasks/phasor/phasor.cpp
Outdated
| } | ||
|
|
||
| double RadToDeg(double rad){ | ||
| return rad * 180 / M_PI; |
Contributor
Author
There was a problem hiding this comment.
надо к единообразию привести, 180.0 и 180
18thday
commented
Jan 14, 2026
04_week/tasks/phasor/phasor.cpp
Outdated
| class Phasor { | ||
| public: | ||
| Phasor() = default; | ||
| Phasor(double A, double rad) { |
18thday
commented
Jan 14, 2026
04_week/tasks/phasor/phasor.cpp
Outdated
| } | ||
|
|
||
| // Сложение коммутативно | ||
| Phasor operator+(double rhs, const Phasor& lhs) { |
Contributor
Author
There was a problem hiding this comment.
слева все-таки lhs справа rhs, можно было просто выразить через предыдущий оператор
18thday
commented
Jan 14, 2026
04_week/tasks/phasor/phasor.cpp
Outdated
| return (lhs + (-rhs)); | ||
| } | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
лишняя пустая строка
18thday
commented
Jan 14, 2026
Contributor
Author
18thday
left a comment
18thday
left a comment
There was a problem hiding this comment.
@notron124 отметил следующие моменты:
- много оптимальных решений
- хорошо читаемый, аккуратный код
- внутри класса обычно не используют для вызова методов
this-> - в задачах классы встречаются лишние копирования, не понравился Resize() в кольцевом буфере
Review fixes
5 week five
6 week six
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.