Open
Conversation
18thday
commented
Jan 19, 2026
| // Состояние буфера | ||
|
|
||
| bool RingBuffer::Empty() const noexcept { | ||
| return !full_ && (head_ == tail_); |
Contributor
Author
There was a problem hiding this comment.
как будто размер с 0 сравнивать эффективно
18thday
commented
Jan 19, 2026
| } | ||
|
|
||
| bool RingBuffer::Full() const noexcept { | ||
| return full_; |
Contributor
Author
There was a problem hiding this comment.
как будто размер с cpacity сравнивать эффективно, и можно не хранить поле, тем более, если вспомнить про выравнивание, то мы помимо одного байта ещё имеем большое выравнивание для хранения поля
18thday
commented
Jan 19, 2026
04_week/tasks/stack/stack.cpp
Outdated
| bool Stack::Pop(){ | ||
| if (stack.empty()){ | ||
| return false; | ||
| } else{ |
Contributor
Author
There was a problem hiding this comment.
else создает лишнюю вложенность
18thday
commented
Jan 19, 2026
04_week/tasks/stack/stack.cpp
Outdated
| } | ||
| } | ||
|
|
||
| int& Stack::Top(){ |
Contributor
Author
There was a problem hiding this comment.
не хватает пробела перед {
18thday
commented
Jan 19, 2026
04_week/tasks/stack/stack.cpp
Outdated
| stack.clear(); | ||
| } | ||
|
|
||
| void Stack::Swap(Stack& stack2){ |
Contributor
Author
There was a problem hiding this comment.
other принято использовать в качестве имени
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.