fix(start): self-heal stale start.running lock on boot#6
Open
Marinski wants to merge 1 commit into
Open
Conversation
start.bat holds the start.running lock for its entire launch window (killing old terminals, parsing config, launching terminals + APIs). Its own exit paths release the lock, but a forced reboot during that window -- the MT5AutoReboot scheduled task, a `docker restart`, or a manual reboot -- kills the script before it can rmdir the lock. The lock dir survives the reboot, so on the next boot start.bat exits with "Another start.bat is already running" and the VM comes up with no terminals until someone deletes the lock by hand. Clear any leftover lock before acquiring it. A fresh boot guarantees no prior start.bat instance is alive (Windows autologon runs it once per boot), so removing a stale lock here is safe and restores automatic recovery from an interrupted start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start.bat holds the start.running lock for its entire launch window (killing old terminals, parsing config, launching terminals + APIs). Its own exit paths release the lock, but a forced reboot during that window - the MT5AutoReboot scheduled task, a
docker restart, or a manual reboot - kills the script before it can rmdir the lock. The lock dir survives the reboot, so on the next boot start.bat exits with "Another start.bat is already running" and the VM comes up with no terminals until someone deletes the lock by hand.Clear any leftover lock before acquiring it. A fresh boot guarantees no prior start.bat instance is alive (Windows autologon runs it once per boot), so removing a stale lock here is safe and restores automatic recovery from an interrupted start.