Correct card generation facts on the rarity page#402
Merged
Conversation
I verified all of this against the decompiled game code (CardRarityOdds, CardFactory, and the event/relic model classes), since the page had a few things wrong. - Rewrote the "random card" section: there are three real behaviors, not two. Default odds (RollWithBaseOdds, realizes ~63/34/3, not 60/37/3), true whole-pool uniform, and fixed-rarity uniform-within-rarity. - Recategorized Glass Eye and Sea Glass: they are fixed-rarity per reward, not free uniform pulls across the whole pool. - Added Colorful Philosophers (#254), Crystal Sphere (#235), and clarified that both Brain Leech options use default odds (#251). - Documented the uncommon-clipping behavior: a negative rare threshold is not floored before the uncommon band stacks, so uncommon dips below its nominal value at a fresh regular-fight reset. Closes #235, #251, #254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the factual errors on the Card Rarity Odds mechanics page and adds the missing card sources. This came out of issues #254, #251, and #235.
I verified everything against the decompiled game code (
CardRarityOdds,CardFactory.CreateForReward, and the event/relic model classes) rather than from memory, since the page had a few things wrong.Changes
RollWithBaseOdds, which checks the rare and uncommon thresholds separately instead of stacking them, so it realizes ~63/34/3, not the 60/37/3 on combat rewards.Note for follow-up
The ~63/34/3 default-odds split looks like a latent bug in the game itself: combat's
Rollstacks the rare and uncommon thresholds, butRollWithBaseOddsdoes not. Documented as-is for now since it is what the code does.Closes #235
Closes #251
Closes #254