Note that default-odds sources can return multiple rares#403
Merged
Conversation
Kaleidoscope, Trial, and the other default-odds sources roll each card independently and never touch the pity offset, so two or more rares can show up. Combat rewards can't, since a rolled rare resets the offset and floors the next slot. Added a short, plain note to the rarity page making that explicit, prompted by a report of a rare in both Kaleidoscope rewards (about a 1 in 130 event, not a bug).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a short, plain note to the Card Rarity Odds page making it explicit that default-odds sources can return more than one rare.
Why
Came from a report of a rare in both Kaleidoscope card rewards, which looked like it should be impossible. It is not. Checked Kaleidoscope against the game code: on pickup it hands out two 3-card rewards, and every card rolls its rarity independently at default odds (
RollWithBaseOdds, ~3% rare) with no pity offset. So multiple rares are by design, a rare in both rewards lands around 1 in 130.Combat rewards behave differently because a rolled rare resets the offset and floors the next slot's rare chance to ~0%. The page already listed Kaleidoscope under default odds but never spelled out that this removes the one-rare-per-reward limit, so the note closes that gap.