Closed
Conversation
Author
|
Wow, that is a 5 years old open PR - sorry, don't remember a thing about it, and does not seem to be maintained. I am closing this ghost PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is intended to solve issue #2 that prevented regexps from having a comma or parentheses in them.
I had to do a small conceptual change: Instead of using
explodeto extract the comma delimited parameters, I am passing anything inside the parentheses directly to the rule handler, as a string.Then, the few rules that do need several arguments, like
in,between,propertyandmethodsimply explode it themselves.