Skip to content

Fix commas in regexp#3

Closed
DannyBen wants to merge 1 commit intoptrofimov:masterfrom
DannyBen:format-parser
Closed

Fix commas in regexp#3
DannyBen wants to merge 1 commit intoptrofimov:masterfrom
DannyBen:format-parser

Conversation

@DannyBen
Copy link
Copy Markdown

This patch is intended to solve issue #2 that prevented regexps from having a comma or parentheses in them.

I had to do a small conceptual change: Instead of using explode to extract the comma delimited parameters, I am passing anything inside the parentheses directly to the rule handler, as a string.

Then, the few rules that do need several arguments, like in, between, property and method simply explode it themselves.

@arsa-dev
Copy link
Copy Markdown

Hi @DannyBen, great work! Take a look of my new PR #6. This PR do the same stuff than your PR but with only one more line of code, and can be better than refactoring all rules that accepts more than one arguments.

@DannyBen DannyBen changed the title Fix commans in regexp Fix commas in regexp Apr 26, 2019
@DannyBen
Copy link
Copy Markdown
Author

Wow, that is a 5 years old open PR - sorry, don't remember a thing about it, and does not seem to be maintained.

I am closing this ghost PR.

@DannyBen DannyBen closed this Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants