Fix missing await in RxRestClient methods causing errors to be swallowed#386
Merged
Fix missing await in RxRestClient methods causing errors to be swallowed#386
Conversation
The postRequest() call was not awaited before calling handleError(), causing server errors (e.g. 403 Forbidden) to be silently swallowed instead of properly thrown to the caller. https://claude.ai/code/session_01XFhhWHka2ZDVQ8udCF3vLN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
The
RxRestClient.get(),RxRestClient.set(), andRxRestClient.delete()methods were not awaiting thepostRequest()call before passing the result tohandleError(). This caused server errors (such as 403 Forbidden responses fromchangeValidatorrejecting writes) to be silently swallowed instead of being thrown to the caller.Changes
Source Code
RxRestClient.get(),RxRestClient.set(), andRxRestClient.delete()properly async by addingawaitto thepostRequest()callshandleError()Tests
/setand/deleteendpoints to expect errors to be thrown whenchangeValidatorrejects writesshould throw an error via handleError when the server rejects a set- verifies thatclient.set()throws when the server rejects the operationshould throw an error via handleError when the server rejects a delete- verifies thatclient.delete()throws when the server rejects the operationTodos
@pubkey
https://claude.ai/code/session_01XFhhWHka2ZDVQ8udCF3vLN