Fix REST endpoint /set not protecting serverOnlyFields#388
Open
Fix REST endpoint /set not protecting serverOnlyFields#388
Conversation
…erwrites The REST endpoint's /set handler used raw client data for doc.patch() and collection.insert(), allowing clients to overwrite server-only fields. Now uses mergeServerDocumentFields (consistent with the replication endpoint) to ensure server-only field values always come from the server document. https://claude.ai/code/session_01VY6XkShCThZjtCYv7iRRmL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
The REST endpoint
/sethandler was not properly protectingserverOnlyFieldsfrom being overwritten by clients. When a client included server-only field values in a write request to/set, those values would be stored directly instead of being ignored. This is a security issue as it allows clients to modify fields that should only be controlled by the server.Solution
The fix applies the same protection mechanism used in the replication endpoint by:
mergeServerDocumentFieldsMonadto ensure server-only field values are always preserved from the server-side document, not taken from client input/setendpoint handlerChanges Made
src/plugins/server/endpoint-rest.ts:
mergeServerDocumentFieldsMonadhelpertest/unit/endpoint-rest.test.ts:
serverOnlyFieldsvia/setCHANGELOG.md:
Test Plan
Added unit test
should not allow clients to overwrite serverOnlyFields via /setthat:lastName)https://claude.ai/code/session_01VY6XkShCThZjtCYv7iRRmL