Fix REST delete endpoint returning 403 when serverOnlyFields configured#389
Open
Fix REST delete endpoint returning 403 when serverOnlyFields configured#389
Conversation
…ured The delete handler passed full documents (including server-only fields) to the changeValidator. The wrapper always rejects documents containing server-only fields, making all deletes fail with 403 Forbidden. Strip server-only fields before passing to changeValidator, consistent with the /set endpoint behavior. https://claude.ai/code/session_01RM8ozNUej31tH5dCBvmaop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
The REST
/deleteendpoint returns a 403 Forbidden error whenserverOnlyFieldsis configured on the endpoint. This occurs because the delete handler passes full documents (including server-only fields) to thechangeValidator, which rejects them since the validation wrapper checks for the presence of server-only fields.Solution
Strip server-only fields from documents before passing them to the
changeValidatorin the delete handler, making the behavior consistent with the/setendpoint which already performs this filtering.Changes
removeServerOnlyFields()on documents before validation, matching the pattern used in the set endpointserverOnlyFieldsis configuredTest Plan
Added unit test
'should allow deleting documents when serverOnlyFields is set'that:serverOnlyFieldsconfiguredExisting tests continue to pass, confirming no regression in other delete scenarios.
https://claude.ai/code/session_01RM8ozNUej31tH5dCBvmaop